Project

General

Profile

Bug #1006

Incorrect selections with numeric or position variables that are used multiple times

Added by Teemu Murtola about 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
selections
Target version:
Affected version - extra info:
4.5-4.5.5
Affected version:
Difficulty:
uncategorized
Close

Description

If selections use variables with a numeric value (e.g., an arithmetic expression), and those variables are referenced more than once, and the variable needs to be evaluated for different set of atoms in different contexts, this in some cases results in an out-of-bounds memory access and/or wrong selection.

As a separate issue, variables with a position value that are referenced more than once cause seg faults.

Found in tests added in https://gerrit.gromacs.org/#/c/1436 and fixed in the same commit for 5.0. The fix should be backported to 4.5.

Associated revisions

Revision caf863c4 (diff)
Added by Teemu Murtola about 5 years ago

Fixes for numeric and position selection variables.

Fixed handling of numeric and position selection variables in cases
where they were referenced multiple times.

Backported from Ifbb585ca.

Fixes #1006.

Change-Id: Ieaa479b4b870e044dc269339be57f6b33533c46e

History

#1 Updated by Teemu Murtola about 5 years ago

  • Status changed from New to Feedback wanted

#2 Updated by Teemu Murtola about 5 years ago

  • Status changed from Feedback wanted to Closed

#3 Updated by Teemu Murtola over 4 years ago

  • Category changed from analysis tools to selections
  • Affected version set to 4.5.5

Also available in: Atom PDF