Project

General

Profile

Feature #1095

Fix all-vs-all kernels

Added by Erik Lindahl almost 5 years ago. Updated over 3 years ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Difficulty:
uncategorized
Close

Description

They were temporarily disabled during testing of the normal kernels, but should be straightforward to turn on again.


Related issues

Related to GROMACS - Bug #1249: no-PBC no-cutoff is broken with SIMD group kernels in 4.6.1Closed2013-05-14
Related to GROMACS - Bug #1134: gromacs 4.6 GB/SA problem and poor performanceClosed2013-01-27
Related to GROMACS - Task #1971: Removing buggy features vs. keeping workflows New

Associated revisions

Revision 6a8acbaa (diff)
Added by Mark Abraham over 4 years ago

Work around for correct treatment of all-vs-all

Neither C or accelerated all-vs-all kernels work in 4.6. The group
SIMD kernels do not work either. The non-accelerated kernel is OK,
though.

Fixes #1249 (for certain values of "fixes"), refs #1095

Change-Id: Id52c0ba110aa915e77859585c2cbfd4d529fe3ca

History

#1 Updated by Erik Lindahl almost 5 years ago

  • Status changed from New to In Progress

#2 Updated by Erik Lindahl almost 5 years ago

  • Assignee set to Erik Lindahl

#3 Updated by Erik Lindahl almost 5 years ago

  • Target version changed from 4.6 to 4.6.1

#4 Updated by Mark Abraham over 4 years ago

  • Target version deleted (4.6.1)
  • Affected version set to 4.6

#5 Updated by Mark Abraham over 4 years ago

Hack in gerrit to stop this code path being triggered https://gerrit.gromacs.org/#/c/2399/

#6 Updated by Rossen Apostolov over 3 years ago

  • Status changed from In Progress to Resolved

we can close this one also

#7 Updated by Mark Abraham over 3 years ago

I don't think the underlying issue is resolved. My patch just stopped wrong results being generated. Resolution ought to be removing or fixing the broken code. This might be trickier now with PD (and perhaps simple search?) removed.

#8 Updated by Rossen Apostolov over 3 years ago

  • Status changed from Resolved to In Progress

#9 Updated by Erik Lindahl over 3 years ago

  • Tracker changed from Bug to Feature

Changing to a feature; we should still improve this for post 5.0 to improve performance, but Mark's fix means we no longer produce any incorrect results.

#10 Updated by Mark Abraham over 1 year ago

  • Related to Task #1971: Removing buggy features vs. keeping workflows added

Also available in: Atom PDF