Project

General

Profile

Bug #1130

include/assert.h collides with system assert.h in 3rd party builds--consider rename to gmx_assert.h or push to 5.0?

Added by Peter Kasson over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Affected version - extra info:
Affected version:
Difficulty:
uncategorized
Close

Description

I've been playing with a tool that links to the Gromacs libraries as well as others (ITK in this case). This tool isn't for inclusion in the gromacs source due to dependencies.
BUT...we get a namespace collision between assert.h in Gromacs and the system assert.h. Renaming to gmx_assert.h fixes this.
Is this something we might want to do in 4.6.X or just address it in the C++ transition (or something else entirely / something I overlooked)?

Thanks!


Related issues

Related to GROMACS - Bug #1223: assert in 4.6Closed

History

#1 Updated by Roland Schulz over 6 years ago

It is already fixed for 5.0.

#2 Updated by Peter Kasson over 6 years ago

  • Status changed from New to Closed

Ok, then let's leave things as they are. Marking this closed. Thanks.

#3 Updated by Christoph Junghans over 6 years ago

That should not be an issue in 4.6 as well.
Gromacs headers should be included as

#include <gromacs/XXX.h>

Most likely it is a < > vs " " issue in some header.

Also available in: Atom PDF