Project

General

Profile

Task #1250

ffopen/ffclose functions name clashes

Added by Rossen Apostolov over 4 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Low
Category:
mdrun
Target version:
Difficulty:
uncategorized
Close

Description

As reported by Ake Sandgren:

Found a problem in gromacs 4.6.1

The ffopen/ffclose functions used clashes with functions that already
exist in some compiler libraries and also with the already existing
ffopen/ffclose function
(https://fs.hlrs.de/projects/craydoc/docs/man/ffiom/72/cat3/ffopen.3c.html)

I temporarily renamed them here.

Associated revisions

Revision cd03ec72 (diff)
Added by Rossen Apostolov over 3 years ago

Rename ffopen and ffclose to gmx_ff*.

There are name clashes with e.g. PathScale compiler.

Fixes #1250.

Change-Id: I3e5e85d9335f2695515483d59d440276823624f0

History

#1 Updated by Mark Abraham over 4 years ago

I expect we can make this go away during the transition to 5.0, but I think we will leave 4.6.x alone.

#2 Updated by Szilárd Páll over 4 years ago

Which are the compilers clashes are observed with?

#3 Updated by Rossen Apostolov over 4 years ago

It's pathscale

#4 Updated by Szilárd Páll over 4 years ago

Last time I checked Pathscale mis-compiled the SIMD kernels so unless all regressiontest pass, ATM it is not even worth considering a fix.

#5 Updated by Mark Abraham about 4 years ago

  • Tracker changed from Bug to Task
  • Assignee changed from Berk Hess to Mark Abraham
  • Priority changed from Normal to Low
  • Target version set to 5.x

While refactoring, consider avoiding these names to work around compilers that are too broken to support an unpolluted C namespace.

#6 Updated by Rossen Apostolov over 3 years ago

shall we rename those for 5.0?

#7 Updated by Mark Abraham over 3 years ago

Yeah sed to gmx_ff* seems straight forward.

#8 Updated by Rossen Apostolov over 3 years ago

ok, I'll fix it then.

#9 Updated by Gerrit Code Review Bot over 3 years ago

Gerrit received a related patchset '1' for Issue #1250.
Uploader: Rossen Apostolov ()
Change-Id: I3e5e85d9335f2695515483d59d440276823624f0
Gerrit URL: https://gerrit.gromacs.org/3139

#10 Updated by Rossen Apostolov over 3 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

#11 Updated by Rossen Apostolov over 3 years ago

  • Status changed from Resolved to Closed

#12 Updated by Teemu Murtola about 3 years ago

  • Assignee changed from Mark Abraham to Rossen Apostolov
  • Target version changed from 5.x to 5.0

Also available in: Atom PDF