syntax error in src/gromacs/legacyheaders/thread_mpi/atomic/xlc_ppc.h
From patch description:
fix declaration that XLC rejected
i have no idea what "volatile char* volatile*" is supposed to do, but
all that is required is "volatile void *" hence that is what i have used
#2 Updated by Sander Pronk almost 6 years ago
- Assignee set to Sander Pronk
This is unfortunately not a typo :-( It's what made the atomics work - in a previous version of the xlc compiler. The documentation of xlc now says that there are built-in atomic functions such as compare and swap, so I'll add a version check and then use those for the newer compilers.
#3 Updated by Jeff Hammond almost 6 years ago
I don't see how that is valid C syntax so it should have been filed as a bug with IBM rather than committed to Gromacs. If all else fails, one can write the code in GNU inline assembly, compile with GCC and link the object code into an XLC build.
I have access to XLC 9, 11 12 (BGP, POWER7 and BGQ, respectively) and can test this code against all of them and provide the appropriate preprocessor magic (i.e. get version-specific as necessary using IBMC - http://sourceforge.net/p/predef/wiki/Compilers/).
In any case, I agree that using the built-in atomics functions are a better idea anyways. I'll work on a patch for all of the aforementioned compilers. BGP and BGQ both have wrappers to LLSC assembly in the driver and I know that at least XLC 11+ supports the GCC macros for atomics.
#4 Updated by Sander Pronk almost 6 years ago
volatile void* volatile p;
is valid C syntax, which means: treat both the pointer value and the item it points at as volatile. This is actually what we want, so perhaps all that needs to be done is to change lines 142&143 to
volatile char* volatile* oldv = oldval;
volatile char* volatile* newv = newval;
volatile char* volatile oldv = oldval;
volatile char* volatile newv = newval;
and make sure the same thing happens on line 86.
#6 Updated by Mark Abraham almost 6 years ago
- volatile char* volatile* oldv = oldval;
- volatile char* volatile* newv = newval;
+ volatile char* volatile oldv = (char *) oldval;
+ volatile char* volatile newv = (char *) newval;
did compile on xlc 12.1 for BG/Q (and GCC 4.4.7 on linux frontend compiler)
#7 Updated by Mark Abraham almost 6 years ago
- Category set to mdrun
- Status changed from New to Fix uploaded
- Target version set to 4.6.3
https://gerrit.gromacs.org/#/c/2450/ looks good to me. Unless Jeff has any further comment, that will make GROMACS 4.6.3.
Working on a proper fix using built-ins will take more time.