Bug #1289
EEL_USER is true when eelPMESWITCH is true
Description
The monster Verlet kernel patch included
#define EEL_USER(e) ((e) == eelUSER || (e) == eelPMEUSER || (e) == (eelPMESWITCH))
I think it should be
#define EEL_USER(e) ((e) == eelUSER || (e) == eelPMEUSER || (e) == (eelPMEUSERSWITCH))
Associated revisions
History
#1 Updated by Mark Abraham over 6 years ago
- Description updated (diff)
#2 Updated by Mark Abraham over 6 years ago
- Description updated (diff)
#3 Updated by Mark Abraham over 6 years ago
- Status changed from New to Fix uploaded
- Assignee changed from Berk Hess to Mark Abraham
#4 Updated by Teemu Murtola over 6 years ago
- Status changed from Fix uploaded to Resolved
- Affected version - extra info set to 4.6-4.6.2
Was fixed in https://gerrit.gromacs.org/#/c/2459/ for 4.6.3 (not possible to set that target version any longer). For some reason, the commit wasn't linked here.
#5 Updated by Mark Abraham over 6 years ago
- % Done changed from 0 to 100
Applied in changeset 242f9f63993333b6a13ffc237a7074597e996567.
#6 Updated by Mark Abraham about 6 years ago
- Status changed from Resolved to Closed
- Target version changed from 4.6.x to 4.6.4
Corrected definition of EEL_USER
Looks like a copy-paste typo occured at some point in the nbnxn
development. EEL_USER is only used in runner.c, and only to issue a
fatal error with user-supplied non-bonded potentials. That clearly
should be not applicable to eelPMESWITCH.
Fixes #1289
Change-Id: I4e987c81aec81a920779dd29d7c52e8b6d233b45