Project

General

Profile

Bug #1289

EEL_USER is true when eelPMESWITCH is true

Added by Mark Abraham about 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Low
Assignee:
Mark Abraham
Category:
mdrun
Target version:
4.6.4
Affected version - extra info:
4.6-4.6.2
Affected version:
4.6.2
Difficulty:
uncategorized
Close

Description

The monster Verlet kernel patch included

#define EEL_USER(e) ((e) == eelUSER || (e) == eelPMEUSER || (e) == (eelPMESWITCH))

(see http://redmine.gromacs.org/projects/gromacs/repository/revisions/release-4-6/entry/include/types/enums.h#L120)

I think it should be

#define EEL_USER(e) ((e) == eelUSER || (e) == eelPMEUSER || (e) == (eelPMEUSERSWITCH))

Associated revisions

Revision 242f9f63 (diff)
Added by Mark Abraham almost 5 years ago

Corrected definition of EEL_USER

Looks like a copy-paste typo occured at some point in the nbnxn
development. EEL_USER is only used in runner.c, and only to issue a
fatal error with user-supplied non-bonded potentials. That clearly
should be not applicable to eelPMESWITCH.

Fixes #1289

Change-Id: I4e987c81aec81a920779dd29d7c52e8b6d233b45

History

#1 Updated by Mark Abraham about 5 years ago

  • Description updated (diff)

#2 Updated by Mark Abraham about 5 years ago

  • Description updated (diff)

#3 Updated by Mark Abraham almost 5 years ago

  • Status changed from New to Fix uploaded
  • Assignee changed from Berk Hess to Mark Abraham

#4 Updated by Teemu Murtola almost 5 years ago

  • Status changed from Fix uploaded to Resolved
  • Affected version - extra info set to 4.6-4.6.2

Was fixed in https://gerrit.gromacs.org/#/c/2459/ for 4.6.3 (not possible to set that target version any longer). For some reason, the commit wasn't linked here.

#5 Updated by Mark Abraham almost 5 years ago

  • % Done changed from 0 to 100

#6 Updated by Mark Abraham over 4 years ago

  • Status changed from Resolved to Closed
  • Target version changed from 4.6.x to 4.6.4

Also available in: Atom PDF