Project

General

Profile

Bug #1355

ThreadMPI.cmake TestAtomic.c check is not reliable

Added by Roland Schulz almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
build system
Target version:
-
Affected version - extra info:
Affected version:
Difficulty:
uncategorized
Close

Description

TestAtomic.c doesn't call any of the atomics. Thus the atomics are only syntax checked. Any compiler error which only occurs when macros are evaluated or compiler errors in later optimization/linker stages can't get noticed. An example is that the usage of sfence on MIC doesn't make the test fail. See https://gerrit.gromacs.org/2690

Associated revisions

Revision 2bd5f64f (diff)
Added by Mark Abraham almost 4 years ago

Call atomics from TestAtomic.c

This exposes more compile-time errors than simply parsing
the definitions. This makes CMake's diagnostics more useful
with respect to atomic operations.

Fixes #1355

Change-Id: Ie1d6f14565700b98988cadc17cb7ac2b78d76ce3

History

#1 Updated by Mark Abraham almost 4 years ago

  • Assignee deleted (Sander Pronk)

For the record, Sander left academe in about July, so please don't assign things to him unless/until we hear from him again! :-)

#2 Updated by Mark Abraham almost 4 years ago

  • Status changed from New to In Progress
  • Assignee set to Mark Abraham

Suggested fix in https://gerrit.gromacs.org/#q,Ie1d6f14565700b98988cadc17cb7ac2b78d76ce3,n,z. Please try it out on MIC - I can't.

#3 Updated by Mark Abraham almost 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

#4 Updated by Rossen Apostolov over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF