Bug #1387
Wrong return value in topsort.c
Description
Function gmx_bool gmx_mtop_bondeds_free_energy(const gmx_mtop_t *mtop)
in src/gmxlib/topsort.c returns always true. I think the correct return
statement should be
return (bPert ? ilsortUNKNOWN : ilsortNO_FE);
instead. Please comment.
Associated revisions
History
#1 Updated by Manuel Luitz about 5 years ago
Typo,
return bPert;
should be the correct return statement
#2 Updated by Mark Abraham about 5 years ago
- Category set to mdrun
- Status changed from New to Accepted
- Assignee set to Berk Hess
- Target version changed from 4.6.x to 4.6.5
Yes, that looks like a bug introduced in ec5d23831a6217a92ac4e3dc36d75e93be5236a9 in http://redmine.gromacs.org/projects/gromacs/repository/revisions/ec5d23831a6217a92ac4e3dc36d75e93be5236a9/diff/src/gmxlib/topsort.c
#3 Updated by Berk Hess about 5 years ago
- Status changed from Accepted to Fix uploaded
- Priority changed from High to Normal
I uploaded the fix to gerrit.
But this was a harmless issue, since it only caused systems with free-energy on, but no perturbed bondeds to sort the bondeds, without any effect on the order, only a little effect on performance.
#4 Updated by Berk Hess about 5 years ago
- Status changed from Fix uploaded to Resolved
- % Done changed from 0 to 100
Applied in changeset 99f228b04707e025a0fd60518c575c1e974ed162.
#5 Updated by Mark Abraham about 5 years ago
- Status changed from Resolved to Closed
Fixed return value of gmx_mtop_bondeds_free_energy
The return value was always true, which was harmless, since it
could only cause a small performance hit of useless sorting.
Fixes #1387
Change-Id: I088a3747ddb3517fbb5e416b791bd542bd49fed2