Project

General

Profile

Bug #1412

GMX_BUILD_OWN_FFTW -- breaks without Fortran compiler?

Added by Peter Kasson almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
build system
Target version:
Affected version - extra info:
4.6-4.6.5
Affected version:
Difficulty:
uncategorized
Close

Description

I encountered an issue in building Gromacs/Native Client where the GMX_BUILD_OWN_FFTW would fail because it was missing a functional fortran compiler. I've worked around this by introducing an option to skip fortran compilation in the FFTW build. Roland asked if this was a general situation and, if so, whether we should set the disable-fortran option as a default. Comments?
(BTW this was in release-4-6, but I think it should apply to master as well)

Thanks!

Associated revisions

Revision ed04865c (diff)
Added by Christoph Junghans almost 4 years ago

cmake: make GMX_BUILD_OWN_FFTW work without fortran compiler

Fixes #1412

Change-Id: I4739c112630ad7e264ce314d2da0b29932ea3041

History

#1 Updated by Christoph Junghans almost 4 years ago

Yes, we should set "--disable-fortran" by default! The fortran support in our internal fftw is anyway unrelated to the long gone fortran support in gromacs.

#2 Updated by Gerrit Code Review Bot almost 4 years ago

Gerrit received a related patchset '1' for Issue #1412.
Uploader: Christoph Junghans ()
Change-Id: I4739c112630ad7e264ce314d2da0b29932ea3041
Gerrit URL: https://gerrit.gromacs.org/2939

#3 Updated by Teemu Murtola almost 4 years ago

  • Status changed from New to Resolved
  • Target version set to 4.6.6
  • Affected version - extra info set to 4.6-4.6.5
  • Affected version changed from 4.6.x to 4.6.5

Was fixed by the linked Gerrit change. Auto-updating the issues in Redmine doesn't seem to work.

#4 Updated by Christoph Junghans almost 4 years ago

We need to merge 4.6 into master and update <https://gerrit.gromacs.org/#/c/2919/&gt;, too.

#5 Updated by Christoph Junghans almost 4 years ago

  • % Done changed from 0 to 100

#6 Updated by Rossen Apostolov almost 4 years ago

Teemu Murtola wrote:

Was fixed by the linked Gerrit change. Auto-updating the issues in Redmine doesn't seem to work.

If you mean auto-updating by the gerrit hook, I've disabled that because it may lead to undesired behaviour.

#7 Updated by Rossen Apostolov almost 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF