Project

General

Profile

Bug #1435

zlib detection is insufficient

Added by Roland Schulz over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
Affected version - extra info:
Affected version:
Difficulty:
uncategorized
Close

Description

The zlib detection has the same problem that libxml had and which was fixed by https://gerrit.gromacs.org/#/c/3005/

Associated revisions

Revision 7fca425b (diff)
Added by Roland Schulz over 3 years ago

Check zlib can actually be linked

Only use zlib compression in tng if zlib can really be linked.
This is equivalent to ee26e1264 for libxml2.

It is slightly simpler than the approach in gmxTestLibXml2
and CheckLibraryExists could be used there too.
This does not detect potential linking errors with shared
libraries similar to those solved in #740 for FFTW.

Fixes #1435

Change-Id: I5009e50b6caf810a12e71ecd83bde2edb21a2b32

History

#1 Updated by Roland Schulz over 3 years ago

  • Assignee set to Magnus Lundborg

#2 Updated by Gerrit Code Review Bot over 3 years ago

Gerrit received a related patchset '1' for Issue #1435.
Uploader: Roland Schulz ()
Change-Id: I5009e50b6caf810a12e71ecd83bde2edb21a2b32
Gerrit URL: https://gerrit.gromacs.org/3197

#3 Updated by Roland Schulz over 3 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

#4 Updated by Roland Schulz over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF