Project

General

Profile

Task #1455

fix regressiontests to correctly rerun and report the mdrun usage

Added by Mark Abraham over 5 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
testing
Target version:
Difficulty:
uncategorized
Close

Description

Some recent changes improved the structure of how we customize our running of mdrun during tests, but as Roland noted at https://gerrit.gromacs.org/#/c/3186/1/gmxtest.pl and https://gerrit.gromacs.org/#/c/3223/ we sometimes re-run mdrun when we should report failure, or vice-versa.

Re-runs should occur in response to an identified error message, and the change to the mdrun command line should reflect that error. Unable to successfully run mdrun should result in an error condition reported correctly to the harness.


Related issues

Related to GROMACS - Task #1587: improve the configurability of regression testsNew

Associated revisions

Revision e5a91a75 (diff)
Added by Roland Schulz over 5 years ago

Fix backup and exit code issues

- Set GMX_MAXBACKUP to 1 (if not set by user) so that tests
don't fail after being run 99 times
Check the exit value of grompp
- Don't rerun mdrun if mdrun failed with any error message
other than those explicitly handeled by how_should_we_rerun_mdrun
for parallelization reasons

Fixes #1455

Change-Id: I5b4d2204d7199cff521f4400143a80b1fab67e5c

History

#1 Updated by Erik Lindahl over 5 years ago

  • Target version changed from 5.0 to 5.x

#2 Updated by Mark Abraham almost 5 years ago

There have been some improvements in the regressiontests repo between 5.0 and 5.1, but it is not clear that the full issue is resolved.

#3 Updated by Mark Abraham over 4 years ago

  • Related to Task #1587: improve the configurability of regression tests added

#4 Updated by Mark Abraham over 3 years ago

  • Status changed from New to Closed
  • Target version changed from 5.x to 5.1

I expect nobody will address this before I kill the old framework

Also available in: Atom PDF