Project

General

Profile

Bug #1477

tng_io + cmake 3

Added by Roland Schulz almost 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Magnus Lundborg
Category:
-
Target version:
5.0
Affected version - extra info:
Affected version:
5.0-rc1
Difficulty:
uncategorized
Close

Description

With cmake 3 rc2 one gets the warning:

CMake Warning (dev) at src/external/tng_io/CMakeLists.txt:3 (project):
  Policy CMP0048 is not set: project() command manages VERSION variables.
  Run "cmake --help-policy CMP0048" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  The following variable(s) would be set to empty:

    PROJECT_VERSION

Associated revisions

Revision 471d8013 (diff)
Added by Erik Lindahl over 6 years ago

Added package version to tng_io CMakelists.txt

Without a package version (for tng_io), the CMake 3 beta
versions will issue warnings.

Fixes #1477.

Change-Id: I4a8f64f70e7372118eecfebb69b4a24cd18835cb

History

#1 Updated by Roland Schulz almost 7 years ago

  • Description updated (diff)

#2 Updated by Gerrit Code Review Bot over 6 years ago

Gerrit received a related patchset '1' for Issue #1477.
Uploader: Erik Lindahl ()
Change-Id: I4a8f64f70e7372118eecfebb69b4a24cd18835cb
Gerrit URL: https://gerrit.gromacs.org/3550

#3 Updated by Erik Lindahl over 6 years ago

  • Status changed from New to Fix uploaded

#4 Updated by Erik Lindahl over 6 years ago

  • Status changed from Fix uploaded to Rejected

This appears to have been fixed in CMake-3.0-rc6, but it might nevertheless be a good idea to add a version number (as uploaded in https://gerrit.gromacs.org/#/c/3550/ ).

#5 Updated by Gerrit Code Review Bot over 6 years ago

Gerrit received a related patchset '1' for Issue #1477.
Uploader: David van der Spoel ()
Change-Id: I4a8f64f70e7372118eecfebb69b4a24cd18835cb
Gerrit URL: https://gerrit.gromacs.org/3614

#6 Updated by Rossen Apostolov over 6 years ago

  • Status changed from Rejected to Fix uploaded

Fix was applied as part of the TNG bump in commit:ac57b327f ( https://gerrit.gromacs.org/#/c/3600/)

#7 Updated by Erik Lindahl over 6 years ago

  • Status changed from Fix uploaded to Resolved

#8 Updated by Erik Lindahl over 6 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF