Project

General

Profile

Bug #1479

g_rama and g_chi print some xvg headers even when -xvg none is set

Added by Chris Neale almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Low
Category:
analysis tools
Target version:
-
Affected version - extra info:
5.0-rc1 and 4.6.5
Affected version:
Difficulty:
uncategorized
Close

Description

In gmx_rama.c, should probably protect:

    fprintf(out, "@    xaxis  tick on\n@    xaxis  tick major 60\n@    xaxis  tick minor 30\n");
    fprintf(out, "@    yaxis  tick on\n@    yaxis  tick major 60\n@    yaxis  tick minor 30\n");
    fprintf(out, "@ s0 symbol 2\n@ s0 symbol size 0.4\n@ s0 symbol fill 1\n");

with:

    if (output_env_get_print_xvgr_codes(oenv))

Same thing goes for the following code in gmx_chi.c:

                fprintf(fp, "# this effort to set graph size fails unless you run with -autoscale none or -autoscale y flags\n");
                fprintf(fp, "@ xaxis tick on\n");
                fprintf(fp, "@ xaxis tick major 90\n");
                fprintf(fp, "@ xaxis tick minor 30\n");
                fprintf(fp, "@ xaxis ticklabel prec 0\n");
                fprintf(fp, "@ yaxis tick off\n");
                fprintf(fp, "@ yaxis ticklabel off\n");
                fprintf(fp, "@ type xy\n");

I didn't check all analysis tools, but the same problem likely exists elsewhere as well.


Related issues

Related to GROMACS - Bug #1407: xvg information leaks through -xvg none in g_cluster Closed 12/13/2013

Associated revisions

Revision 82f6f587 (diff)
Added by Erik Lindahl almost 3 years ago

Avoid writing xvgr formatting with -xvg none

Several tools were writing xvgr formatting code directly
to output files, even when the users selects -xvg none as
a command line option.

Fixes #1407, #1479.

Change-Id: I1db10c2ad7455332e2a415a922885cddaec5efd1

History

#1 Updated by Teemu Murtola almost 3 years ago

  • Related to Bug #1407: xvg information leaks through -xvg none in g_cluster added

#2 Updated by Gerrit Code Review Bot almost 3 years ago

Gerrit received a related patchset '1' for Issue #1479.
Uploader: Erik Lindahl ()
Change-Id: I1db10c2ad7455332e2a415a922885cddaec5efd1
Gerrit URL: https://gerrit.gromacs.org/3560

#3 Updated by Erik Lindahl almost 3 years ago

  • Status changed from New to Fix uploaded

#4 Updated by Erik Lindahl almost 3 years ago

  • Status changed from Fix uploaded to Resolved
  • % Done changed from 0 to 100

#5 Updated by Erik Lindahl almost 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF