Project

General

Profile

Bug #1531

gmx bar fatal errors write garbage values

Added by Mark Abraham almost 3 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Low
Assignee:
-
Category:
analysis tools
Target version:
-
Affected version - extra info:
probably all 4.6 affected
Affected version:
Difficulty:
uncategorized
Close

Description

Once upon a time, gmx bar had a struct with a double lambda that was fine to pass to a printf("%f") in a fatal error in (say) barres_list_create(), but lambda is now a pointer to some kind of struct and the fatal errors print whatever junk is the result of converting the pointer.

Associated revisions

Revision 5aba10c4 (diff)
Added by Erik Lindahl over 2 years ago

Fix formatting of fatal errors in g_bar

The lambda value has changed from a floating
point number into a complicated vector, so we
now have a small routine that formats the contents
of this vector for the fatal error routines.

Fixes #1531.

Change-Id: I41f7d27c16a76879d6f1f7dc669655d755c1ce3d

History

#1 Updated by Mark Abraham almost 3 years ago

  • Description updated (diff)

#2 Updated by Gerrit Code Review Bot almost 3 years ago

Gerrit received a related patchset '1' for Issue #1531.
Uploader: Erik Lindahl ()
Change-Id: I41f7d27c16a76879d6f1f7dc669655d755c1ce3d
Gerrit URL: https://gerrit.gromacs.org/3832

#3 Updated by Erik Lindahl almost 3 years ago

  • Status changed from New to Fix uploaded

Caveat emperor: I only wrote a fix that compiles and should work, but I haven't had a chance to test it on any file that generates the fatal errors.

#4 Updated by Mark Abraham almost 3 years ago

Thanks. Unfortunately I don't have a reliable test case either. I found it before we switched to Michael's test stuff when bug-hunting in June, so I might be able to reproduce if I track my timestamps. Oh well.

#5 Updated by Erik Lindahl almost 2 years ago

  • Status changed from Fix uploaded to Resolved

Nobody complained, so I assume my fix worked.

#6 Updated by Erik Lindahl almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF