Project

General

Profile

Bug #1555

selection-test fails if input file has Windows line ending

Added by Roland Schulz over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
selections
Target version:
Affected version - extra info:
Affected version:
Difficulty:
uncategorized
Close

Description

Under Windows the file ending depends on the git configuration. If the file ending is Windows (CRLF) for src/gromacs/selection/tests/selfile.dat then several of the selection-test unit tests fail. I see the error both under Cygwin and Linux (where there wouldn't be any good reason to ever have that file with CRLF - just means that one can debug it outside of Cygwin)

Associated revisions

Revision 013e8ef6 (diff)
Added by Teemu Murtola over 2 years ago

Make selections ignore \r in input

Now the selection engine treats \r (as well as various other space
characters) the same as a space. Added a unit test for this.
There is an extra trailing space in some cases that may be more common
with \r\n than otherwise, but that is a separate, mostly cosmetic
issue.

Fixes #1555

Change-Id: I78dfe8e477133b98a98fecf1fad243262f9b30c8

History

#1 Updated by Gerrit Code Review Bot over 2 years ago

Gerrit received a related patchset '1' for Issue #1555.
Uploader: Teemu Murtola ()
Change-Id: I78dfe8e477133b98a98fecf1fad243262f9b30c8
Gerrit URL: https://gerrit.gromacs.org/3763

#2 Updated by Teemu Murtola over 2 years ago

  • Category set to selections
  • Status changed from New to Fix uploaded
  • Assignee set to Teemu Murtola
  • Target version set to 5.0.1

#3 Updated by Teemu Murtola over 2 years ago

  • Status changed from Fix uploaded to Closed

Also available in: Atom PDF