Project

General

Profile

Bug #1735

BUILD_OWN_FFTW triggers no-SSE warning

Added by Berk Hess about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Mark Abraham
Category:
build system
Target version:
5.0.6
Affected version - extra info:
Affected version:
5.0.5
Difficulty:
uncategorized
Close

Description

Due to my change d33720e6 setting BUILD_OWN_FFTW generates a warning about no SSE being enabled in FFTW. This is because I replaced the positive test on AVX by a negative test on SSE and AVX_128. Apparently BUILD_OWN_FFTW sets HAVE_SIMD somewhere. I don't fully understand how this works, so it might be better if someone else fixes this.

Associated revisions

Revision 50b9000d (diff)
Added by Mark Abraham about 3 years ago

Fix own-FFTW build

Recent changes broke the expectation that the own-FFTW build attempts
to pretend to have run SIMD-support tests on the build that it has not
yet performed. This is all more complicated than it needs to be,
and will be refactored in master branch.

Fixes #1735

Change-Id: I9e5f296b199b6b5af685fa2ba87cc962a41a251f

Revision 6ce08bf1 (diff)
Added by Mark Abraham about 3 years ago

Refactor FFTW setup

It proved bug-prone to have both own-FFTW and find-FFTW mechanisms try
to fulfil the same contract, and it was not needed in the first
place. We do not need to fake the results of SIMD tests just to avoid
our own warnings (and that was all that they were used for; mdrun does
further SIMD-support detection at run time after possible dynamic
linking of FFTW.

Now we check when there is something to check, and not when there is
not. Removed TODOs and comments no longer appropriate for the
refactored code.

Refs #1735

Change-Id: Ib470fc29cb0b9ccad998698e9b9bda4af9f99dbf

History

#1 Updated by Mark Abraham about 3 years ago

  • Status changed from New to In Progress
  • Assignee set to Mark Abraham

#2 Updated by Gerrit Code Review Bot about 3 years ago

Gerrit received a related patchset '1' for Issue #1735.
Uploader: Mark Abraham ()
Change-Id: I9e5f296b199b6b5af685fa2ba87cc962a41a251f
Gerrit URL: https://gerrit.gromacs.org/4589

#3 Updated by Gerrit Code Review Bot about 3 years ago

Gerrit received a related patchset '1' for Issue #1735.
Uploader: Mark Abraham ()
Change-Id: Ib470fc29cb0b9ccad998698e9b9bda4af9f99dbf
Gerrit URL: https://gerrit.gromacs.org/4590

#4 Updated by Berk Hess about 3 years ago

  • Status changed from In Progress to Closed

Fixed for 5.0.6.

Also available in: Atom PDF