Project

General

Profile

Task #1764

review non-advanced CMake variables

Added by Szilárd Páll over 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
build system
Target version:
Difficulty:
uncategorized
Close

Description

A number of CMake variables have showed up as non-advanced recently and I think they probably should all be marked advanced. Here's a list of what I noticed, feel free to extend the list if you know of others:
  • CMAKE_EXE_LINKER_FLAGS_REFEREN, CMAKE_EXE_LINKER_FLAGS_RELWITH
  • HAVE_LIBM
    * PYTHONMODULE_PYGMENTS
New(er) troublemakers:
  • CUDA_USE_STATIC_CUDA_RUNTIME -- useful or not?
  • CUDA_dl_LIBRARY, CUDA_rt_LIBRARY ( CMake 3.3 and later)

Associated revisions

Revision 0dbf5ddb (diff)
Added by Teemu Murtola over 4 years ago

Remove status messages about Sphinx detection

Make FindSphinx.cmake and FindPythonModule.cmake respect the QUIET
option, and pass that to find_package() to not print out information on
every CMake run. Most people will not care whether these are found or
not, and being silent in all cases is the same approach as is used for
Doxygen.

In master, it could be useful to change at least some of the documentation
build rules such that they require GMX_DEVELOPER_BUILD to be set, and
that could also enable messages about not finding the components needed
for the documentation build, but that is outside the scope of this
change.

Fixes part of #1761 and #1764.

Change-Id: I196f5e66c94fe4247ae28bd230a469acbaad939a

Revision 39373379 (diff)
Added by Szilárd Páll over 3 years ago

Mark more variables as advanced

CMake 3.x introduced a few more non-advanced CUDA cache variables that
most users do not care about, so this commit hides them.

Refs #1764

Change-Id: I926b03ece080d8f8255e37dc5471275d48956d49

Revision 0bf91807 (diff)
Added by Mark Abraham over 3 years ago

Make more CMake variables advanced

This keeps the ccmake display down to things users are reasonably
likely to want to change.

Fixes #1764

Change-Id: Ia78387bb32f5d6c7f6b82e453b155fdf657a044a

History

#1 Updated by Szilárd Páll over 4 years ago

  • Description updated (diff)

#2 Updated by Szilárd Páll over 3 years ago

  • Description updated (diff)
  • Target version set to 5.1.3

#3 Updated by Gerrit Code Review Bot over 3 years ago

Gerrit received a related patchset '1' for Issue #1764.
Uploader: Szilárd Páll ()
Change-Id: I926b03ece080d8f8255e37dc5471275d48956d49
Gerrit URL: https://gerrit.gromacs.org/5782

#4 Updated by Gerrit Code Review Bot over 3 years ago

Gerrit received a related patchset '2' for Issue #1764.
Uploader: Mark Abraham ()
Change-Id: Ia78387bb32f5d6c7f6b82e453b155fdf657a044a
Gerrit URL: https://gerrit.gromacs.org/5921

#5 Updated by Mark Abraham over 3 years ago

  • Status changed from Feedback wanted to Fix uploaded

That takes care of all the known issues

#6 Updated by Mark Abraham over 3 years ago

  • Status changed from Fix uploaded to Resolved

#8 Updated by Mark Abraham over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF