Project

General

Profile

Bug #1776

Resource efficiency check incorrectly warns with thread-MPI

Added by Erik Lindahl over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Affected version - extra info:
Affected version:
Difficulty:
uncategorized
Close

Description

The new check_resource_division_efficiency() has an #ifdef where the functionality is only executed if both OpenMP and MPI are available, and if this is not true it warns that only a single core can be used. This is not correct, since thread-MPI still works fine.

Associated revisions

Revision 90d9828b (diff)
Added by Erik Lindahl over 4 years ago

Fix incorrect warning about only using single core

check_resource_division_efficiency() warned that only
a single core could be used, even when one of
thread-MPI or OpenMP support was present, but not both.

Fixes #1776.

Change-Id: I6ac98954c2ef74ed860750627f7a1b9f0710561e

History

#1 Updated by Gerrit Code Review Bot over 4 years ago

Gerrit received a related patchset '2' for Issue #1776.
Uploader: Erik Lindahl ()
Change-Id: I6ac98954c2ef74ed860750627f7a1b9f0710561e
Gerrit URL: https://gerrit.gromacs.org/4891

#2 Updated by Erik Lindahl over 4 years ago

  • Status changed from New to Fix uploaded

#3 Updated by Erik Lindahl over 4 years ago

  • Status changed from Fix uploaded to Resolved
  • % Done changed from 0 to 100

#4 Updated by Mark Abraham over 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF