Project

General

Profile

Task #1908

remove external dependencies that are sometimes problematic

Added by Mark Abraham over 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
core library
Target version:
Difficulty:
uncategorized
Close

Description

libxml2 is currently required for handling reference data for tests, which means users and developers need a version available that can pass our linking test and will work when compiling our actual code. That isn't straightforward - it works best to disable support for zlib and python when configuring libxml2, but this is all a hassle. Instead we could use one of several freely available lightweight XML-handling libraries and avoid such problems. We can leave the infrastructure for libxml2 handling in place while patches in Gerrit might still want it.

zlib is an optional dependency for TNG, but has a permissive license and builds warning-free (or nearly) with recent gcc and clang, so we could just bundle zlib with TNG, and thus GROMACS. Magnus Lundborg this this may be reasonable and will try to look into it.

Associated revisions

Revision a34f8680 (diff)
Added by Teemu Murtola about 3 years ago

Update bundled TNG

This commit bundles 6e41191016 from the TNG repo.

Required TNG 1.7.10 in future, which is the first version to include
support for the build system features used here.

Update the build system to use imported targets and interface properties
that TNG now provides. Add support for building TNG that also bundles
zlib, which reduces the dependency footprint of GROMACS, which is
important for portability and ease of installation.

Refs #1908.

Change-Id: Ibc94d5a9470136331045738f105634ec95fdb455

History

#1 Updated by Gerrit Code Review Bot over 3 years ago

Gerrit received a related patchset '2' for Issue #1908.
Uploader: Mark Abraham ()
Change-Id: I6153136b67b41e7141fc3f1fc8ee4005a72c90f1
Gerrit URL: https://gerrit.gromacs.org/5653

#2 Updated by Gerrit Code Review Bot over 3 years ago

Gerrit received a related patchset '10' for Issue #1908.
Uploader: Mark Abraham ()
Change-Id: Ibc94d5a9470136331045738f105634ec95fdb455
Gerrit URL: https://gerrit.gromacs.org/5815

#3 Updated by Mark Abraham over 3 years ago

  • Status changed from New to Fix uploaded

#4 Updated by Mark Abraham over 3 years ago

libxml2 is gone, the transitive dependency on zlib via tng remains, but is under review in gerrit

#5 Updated by Mark Abraham about 3 years ago

  • Target version changed from 2016 to 2018

#6 Updated by Mark Abraham over 2 years ago

  • Status changed from Fix uploaded to Resolved

https://gerrit.gromacs.org/#/c/5815/ updated GROMACS to use the updated TNG that bundles zlib, closing this issue.

#7 Updated by Mark Abraham over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF