Project

General

Profile

Bug #2008

-msse2 not passed to compiler flags with -DGMX_SIMD=SSE2

Added by Nicholas Breen over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
build system
Target version:
Affected version - extra info:
2016-rc1 & master
Affected version:
Difficulty:
uncategorized
Close

Description

The -msse2 compiler flag is not properly passed down when specifying GMX_SIMD=SSE2, due to two missing lines in deef4d6 . Mini-patch:

--- gromacs-2016~rc1.orig/cmake/gmxManageSimd.cmake
+++ gromacs-2016~rc1/cmake/gmxManageSimd.cmake
@@ -142,6 +142,8 @@ elseif(GMX_SIMD STREQUAL "SSE2")
         gmx_give_fatal_error_when_simd_support_not_found("SSE2" "disable SIMD support (slow)" "${SUGGEST_BINUTILS_UPDATE}")
     endif()

+    set(SIMD_C_FLAGS "${TOOLCHAIN_C_FLAGS}")
+    set(SIMD_CXX_FLAGS "${TOOLCHAIN_CXX_FLAGS}")
     set(GMX_SIMD_X86_${GMX_SIMD} 1)
     set(SIMD_STATUS_MESSAGE "Enabling SSE2 SIMD instructions")

Associated revisions

Revision 98977212 (diff)
Added by Mark Abraham over 4 years ago

Add toolchain flags for SSE2 compilation

This is how the code should be, though my testing didn't need it.

Also fixed function documentation.

Fixes #2008

Change-Id: Ic1e1c16d22e054e9f741d91c667305de7398cd30

History

#1 Updated by Mark Abraham over 4 years ago

Thanks, looks like a straightforward typo in a refactoring change that I made :-(

#2 Updated by Gerrit Code Review Bot over 4 years ago

Gerrit received a related patchset '1' for Issue #2008.
Uploader: Mark Abraham ()
Change-Id: Ic1e1c16d22e054e9f741d91c667305de7398cd30
Gerrit URL: https://gerrit.gromacs.org/6062

#3 Updated by Mark Abraham over 4 years ago

  • Status changed from New to Resolved

#4 Updated by Mark Abraham over 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF