Project

General

Profile

Feature #2072

target hardware description is silent about the result

Added by Mark Abraham over 2 years ago. Updated 9 months ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
build system
Target version:
Difficulty:
simple
Close

Description

Currently cmake/gmxDetectTargetArchitecture.cmake is silent about its results, which makes it difficult to know what the result was, e.g. in places that build with strange platforms, like Debian and Fedora build farms. Raised at https://gerrit.gromacs.org/#/c/6321/

We should write a single line status message to cmake output when we detect the identity of the target, and a single line when we have not detected any target.


Related issues

Related to GROMACS - Task #1907: keeping compile- and run-time CPU/arch detection consistentAccepted

Associated revisions

Revision c3a53d77 (diff)
Added by Dan Horák over 2 years ago

Fix x86 conditional

The CpuInfoTest.SupportLevel testcase fails on s390x because wrong
condition in src/gromacs/hardware/tests/cpuinfo.cpp is used. Fixed
this by setting GMX_TARGET_X86 to 0 or 1 in all cases, both for
GROMACS CMake detection and GROMACS build.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1390149

Refs #2072

Change-Id: Id50fd65c6228a25f2bb2eca684d680a2b34d2263

History

#1 Updated by Gerrit Code Review Bot over 2 years ago

Gerrit received a related patchset '2' for Issue #2072.
Uploader: Mark Abraham ()
Change-Id: Id50fd65c6228a25f2bb2eca684d680a2b34d2263
Gerrit URL: https://gerrit.gromacs.org/6321

#2 Updated by Szilárd Páll over 2 years ago

  • Related to Task #1907: keeping compile- and run-time CPU/arch detection consistent added

#3 Updated by Mark Abraham about 2 years ago

  • Target version changed from 2018 to 2019

#4 Updated by Mark Abraham 9 months ago

  • Status changed from New to Resolved

#5 Updated by Mark Abraham 9 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF