Project

General

Profile

Bug #2098

NVML linking fails

Added by Mark Abraham almost 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
build system
Target version:
Affected version - extra info:
Affected version:
Difficulty:
simple
Close

Description

The fix for #2087 cleared GMX_EXTRA_LIBRARIES after NVML handling set it, so linking with NVML fails. Found by Magnus Lundborg on local tcbs machines and diagnosed by Mark.

Either we should not clear such variables, clear them earlier, or use some other mechanism for linking to NVML.

Associated revisions

Revision e29363ee (diff)
Added by Mark Abraham over 2 years ago

Initialize GMX_*_LIBRARIES cmake variables earlier

NVML linking got broken by the way the introduction of separate
variables also set them to empty initial values, but did so after
gmxManageGPU.cmake tried to set GMX_EXTRA_LIBRARIES.

Made minor improvements to the documentation

Fixes #2098
Refs #2087

Change-Id: I25116c6caa0d13bf9bb06854c8e3a1e3f7e8afb2

History

#1 Updated by Mark Abraham almost 3 years ago

  • Description updated (diff)

#2 Updated by Gerrit Code Review Bot almost 3 years ago

Gerrit received a related patchset '1' for Issue #2098.
Uploader: Mark Abraham ()
Change-Id: gromacs~master~I25116c6caa0d13bf9bb06854c8e3a1e3f7e8afb2
Gerrit URL: https://gerrit.gromacs.org/6413

#3 Updated by Mark Abraham over 2 years ago

  • Status changed from New to Resolved

#4 Updated by Mark Abraham over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF