Project

General

Profile

Bug #2373

gmx -nice can't work

Added by Mark Abraham 7 months ago. Updated 7 months ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
core library
Target version:
-
Affected version - extra info:
Affected version:
Difficulty:
uncategorized
Close

Description

In CommandLineModuleManager::Impl::processCommonOptions there's a hardcoded assumption that the gmx wrapper binary will only take no-argument options. Many of its options are booleans, but -nice takes an integer, which leads to

Command line:
  gmx -nice 19

-------------------------------------------------------
Program:     gmx, version 2018-rc1-dev-20180103-f826c0888-dirty
Source file: src/gromacs/commandline/cmdlineparser.cpp (line 279)
Function:    void gmx::CommandLineParser::parse(int*, char**)

Error in user input:
Invalid command-line options
  In command-line option -nice
    Too few (valid) values

For more information and tips for troubleshooting, please check the GROMACS
website at http://www.gromacs.org/Documentation/Errors
-------------------------------------------------------

History

#1 Updated by Mark Abraham 7 months ago

  • Priority changed from Normal to Low

Not urgent to fix

#2 Updated by Erik Lindahl 7 months ago

Short-term I would suggest we change it so it does not take any argument, but just runs at nice 19 if specified.

I see little reason to execute Gromacs at any nice level that is not 0 or 19 (well, maybe 19 would be useful for hardcore people ;)

#3 Updated by Teemu Murtola 7 months ago

It is not clear from the issue description or the title, but, e.g., gmx mdrun -nice 19 should still work, and that is likely what everyone would intuitively use, so there is not much loss in functionality.

But adding 19 as a default value should also be trivial.

#4 Updated by Mark Abraham 7 months ago

Teemu Murtola wrote:

It is not clear from the issue description or the title, but, e.g., gmx mdrun -nice 19 should still work, and that is likely what everyone would intuitively use, so there is not much loss in functionality.

But adding 19 as a default value should also be trivial.

I meant gmx -nice 19 mdrun can't work, which I thought should work, because gmx -h lists it as an available option. Longer term, several of those make sense to move to being available as default flags for tools (-h, -hidden, -nice) and not as flags to gmx itself, and some can be their own tool (-version, -copyright)

Also available in: Atom PDF