Project

General

Profile

Task #2395

break up commrec

Added by Mark Abraham about 1 year ago. Updated 7 months ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
mdrun
Target version:
Difficulty:
uncategorized
Close

Description

t_commrec currently handles lots of things and goes lots of places. We should break it into pieces as suggested in the checklist.

This will make it much easier to deploy modules that might be exposed by an API, or implement standard interfaces for command-line options, etc.


Checklist

  • multi-simulation handler, including communicator
  • physical node communicator - removing various places where we make temporary ones
  • DD aspects
  • duty aspects - PP vs PME vs both

Associated revisions

Revision f8937dc1 (diff)
Added by Mark Abraham about 1 year ago

Remove commrec from hardware detection

This is preparatory refactoring for aspects of #2395

The OpenCL logic was ineffective, because duty is not yet decided, and
anyway we might soon want the detection on PME-only ranks.

Replaced the thread-MPI single-rank assertion with a more direct
implementation.

Minimized contents of detecthardware.h

Refs #2395

Change-Id: I03af65805bd14515a0213d511ae8cdb627c2f05c

History

#1 Updated by Mark Abraham about 1 year ago

f746a4a4aedb76995 already started on this effort

#2 Updated by Gerrit Code Review Bot about 1 year ago

Gerrit received a related patchset '1' for Issue #2395.
Uploader: Mark Abraham ()
Change-Id: gromacs~master~I03af65805bd14515a0213d511ae8cdb627c2f05c
Gerrit URL: https://gerrit.gromacs.org/7531

#3 Updated by Mark Abraham about 1 year ago

4868388f24ecee03d75d and 9a2e38a91c0621d2ecbf1 also made progress here

#4 Updated by Mark Abraham about 1 year ago

  • Description updated (diff)
  • Status changed from New to In Progress

#5 Updated by Mark Abraham 7 months ago

  • Target version changed from 2019 to 2020

Also available in: Atom PDF