Project

General

Profile

Bug #243

free of inappropriate pointer in gmx_parallel_3dfft_destroy

Added by Mark Abraham almost 11 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Erik Lindahl
Category:
mdrun
Target version:
Affected version - extra info:
Affected version:
Difficulty:
uncategorized
Close

Description

In "gmx_parallel_3dfft_destroy" in src/mdlib/gmx_parallel_3dfft.c on line 516 "free" is used to deallocate pfft_setup->work which was formerly created with "malloc", but then subject to alignment constraint in "gmx_parallel_3dfft_init". It correctly fails to deallocate pfft_setup->work2, which was also "malloc"ed then aligned. To fix, remove line 516 containing the "free".

This function is never called, so it can't cause a problem right now.

History

#1 Updated by Erik Lindahl almost 11 years ago

Fixed. We now properly save the original pointers in the structure and free those instead.

Also available in: Atom PDF