Project

General

Profile

Bug #2450

Task #2454: OpenCL infrastructure improvements

OpenCL runtime version check missing

Added by Szilárd Páll over 1 year ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Category:
mdrun
Target version:
Affected version - extra info:
Affected version:
Difficulty:
uncategorized
Close

Description

We missing the check of the device and driver OpenCL version capability against the minimum required.

Associated revisions

Revision 76336a1c (diff)
Added by Szilárd Páll 9 months ago

Runtime check of device OpenCL support

This change adds a runtime check of the OpenCL device version support
against the minimum requirement along some minor refactoring.

Fixes #2450

Change-Id: I0622d8f93b97d877d40fbaa65194f0db8442ffd5

History

#1 Updated by Szilárd Páll over 1 year ago

  • Description updated (diff)
  • Assignee set to Szilárd Páll

I think we can reduce the work by not worth fixing it in 2018 because one would be hard-pressed to find a GPU from a vendor that passes the (only) existing check, but is not at least v1.1. However, bumping the requirement to 1.2 means that we will have some older devices not meeting the requirements (e.g. NVIDIA Fermi).

#2 Updated by Szilárd Páll over 1 year ago

There was a bit of a misunderstanding, clGetDeviceInfo(... CL_DRIVER_VERSION ...) returns the version of the OpenCL vendor driver, e.g. for NVIDIA something like 384.98. This is not too useful for checking compatibility, but it would be useful to report in the mdrun -version header.

#3 Updated by Szilárd Páll over 1 year ago

Szilárd Páll wrote:

This is not too useful for checking compatibility, but it would be useful to report in the mdrun -version header.

Correction: that would be useful as long as we don't allow different vendor's devices in the same run --
and even then, the error that should prevent this (ATM actually this is missing) comes after the header is printed. Such info might be better in the device detection output next to the name/vendor/etc.

#4 Updated by Gerrit Code Review Bot over 1 year ago

Gerrit received a related patchset '1' for Issue #2450.
Uploader: Szilárd Páll ()
Change-Id: gromacs~master~I0622d8f93b97d877d40fbaa65194f0db8442ffd5
Gerrit URL: https://gerrit.gromacs.org/7674

#5 Updated by Mark Abraham over 1 year ago

It would be good to have a master "OpenCL infrastructure improvements" redmine task so that people can find related work via the hierarchy.

#6 Updated by Szilárd Páll over 1 year ago

  • Parent task set to #2454

#7 Updated by Gerrit Code Review Bot 9 months ago

Gerrit received a related patchset '1' for Issue #2450.
Uploader: Szilárd Páll ()
Change-Id: gromacs~release-2019~I0622d8f93b97d877d40fbaa65194f0db8442ffd5
Gerrit URL: https://gerrit.gromacs.org/8840

#8 Updated by Szilárd Páll 9 months ago

  • Status changed from New to Fix uploaded

#9 Updated by Szilárd Páll 9 months ago

  • Status changed from Fix uploaded to Resolved

#10 Updated by Paul Bauer 9 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF