Bug #2460
Allow inclusion of user libraries through CMake cache variables
Description
In the current method of initializing the GMX_*_LIBRARIES variables in the main CMakeLists.txt, the set() command will ignore cache variables of the same name. Since GMX_EXTRA_LIBRARIES, GMX_COMMON_LIBRARIES, and GMX_PUBLIC_LIBRARIES are initialized to "" with a local set() command, any customization of the libraries through cache variables or compilation flags (e.g. -DGMX_COMMON_LIBRARIES=library.so) is ignored.
By simply initializing the variables to their "original" values (even if nonexistent) will still allow for appending later, without ignoring cache variables.(e.g. set(GMX_EXTRA_LIBRARIES "${GMX_EXTRA_VARIABLES}")
)
History
#1 Updated by Mark Abraham almost 3 years ago
- Target version deleted (
2018.1) - Affected version - extra info set to all versions
Yes, I'm sure there's various ways to improve that.
If you'd like to propose a patch, you'd be very welcome to do so at https://gerrit.gromacs.org (instructions here http://www.gromacs.org/Developer_Zone/Git/Gerrit)
#2 Updated by Gerrit Code Review Bot almost 3 years ago
Gerrit received a related patchset '2' for Issue #2460.
Uploader: Michael Quevillon (mquevill@nd.edu)
Change-Id: gromacs~master~I061fe0348557c3307749a6820226df2cd756a78a
Gerrit URL: https://gerrit.gromacs.org/7708