Project

General

Profile

Task #2529

Feature #2054: PME on GPU

Task #2453: PME OpenCL porting effort

Improve test timeouts handling

Added by Aleksei Iupinov 5 months ago. Updated 14 days ago.

Status:
Closed
Priority:
Normal
Category:
testing
Target version:
Difficulty:
simple
Close

Description

With PME OpenCL change https://gerrit.gromacs.org/7877 mdunt-test takes about 160 secodns to run on one of the Jenkins machines.
Current timeout is 120 seconds, so the change just lazily ups the maximum to 180 as of now (src/testutils/TestMacros.cmake:106).
This should be formulated better by an additional option like GPU_INTEGRATION_TEST, to allow for customizable timeouts per test.

Associated revisions

Revision bdebbbac (diff)
Added by Szilárd Páll 27 days ago

Bump test timeout only for OpenCL integration tests

The OpenCL JIT time can make the mdrun integration tetsts time out, so
we need to bump the timoeouts. This change enables a double (240
seconds) timeout only for OpenCL builds.

Fixes #2529

Change-Id: Id0dd3a13f7b5edc5642bbae65de44c125993c7d5

History

#1 Updated by Szilárd Páll 27 days ago

On the current bs-gpu01 slave that's planned to be used for verification the times drop a bit:

      Start 36: MdrunTests
36/45 Test #36: MdrunTests ..........................   Passed   69.42 sec
      Start 37: MdrunMpiTests
37/45 Test #37: MdrunMpiTests .......................   Passed   41.12 sec

On ROCm:

      Start 36: MdrunTests
36/45 Test #36: MdrunTests ..........................   Passed   92.58 sec
      Start 37: MdrunMpiTests
37/45 Test #37: MdrunMpiTests .......................   Passed   55.81 sec
      Start 38: GmxapiExternalInterfaceTests

Still, we probably want to leave some margin, so I could add a new option to the test macro that bumps the timeout for OpenCL builds.

#2 Updated by Gerrit Code Review Bot 27 days ago

Gerrit received a related patchset '1' for Issue #2529.
Uploader: Szilárd Páll ()
Change-Id: gromacs~master~Id0dd3a13f7b5edc5642bbae65de44c125993c7d5
Gerrit URL: https://gerrit.gromacs.org/8410

#3 Updated by Szilárd Páll 27 days ago

  • Status changed from New to Fix uploaded
  • Assignee set to Szilárd Páll

#4 Updated by Mark Abraham 27 days ago

  • Target version changed from future to 2019

#5 Updated by Szilárd Páll 27 days ago

  • Status changed from Fix uploaded to Resolved

#6 Updated by Mark Abraham 14 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF