Project

General

Profile

Bug #2571

clang-tidy cmake needs improvement

Added by Mark Abraham 7 days ago. Updated 6 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
build system
Target version:
Affected version - extra info:
Affected version:
Difficulty:
uncategorized
Close

Description

I found this while running a build manually on the slave where we have the clang-tidy checker running. I configured with

$ /opt/cmake/3.11.4/bin/cmake /home/jenkins/workspace/Matrix_PreSubmit_master@2/1d16e2ee/gromacs -DCLANG_TIDY=clang-tidy-6 -DCMAKE_BUILD_TYPE=ASAN -DCMAKE_CXX_COMPILER=clang++-6 '-DCMAKE_CXX_LINK_FLAGS=-Wl,-rpath,/usr/bin/../lib64 -L/usr/bin/../lib64' -DCMAKE_C_COMPILER=clang-6 -DCMAKE_INSTALL_PREFIX=/home/jenkins/workspace/Matrix_PreSubmit_master@2/1d16e2ee/test-install -DGMX_CLANG_TIDY=ON -DGMX_COMPILER_WARNINGS=ON -DGMX_DEFAULT_SUFFIX=OFF -DGMX_GPU=OFF -DGMX_HWLOC=OFF -DGMX_OPENMP=OFF -DGMX_SIMD=None -DGMX_USE_RDTSCP=DETECT
...
-- Looking for inttypes.h - found
ERRORclang-tidy not found.
-- Configuring done

Why that happens on this slave is less important than that the configuration should fail if clang tidy isn't found and the user asked for it to be used.

Associated revisions

Revision f985ff31 (diff)
Added by Roland Schulz 6 days ago

Fix clang-tidy cmake messages

Fixes #2571

Change-Id: Ibae0b68e30fdcdc5f57cb6ff7c5b78a44df3fb01

History

#1 Updated by Gerrit Code Review Bot 6 days ago

Gerrit received a related patchset '1' for Issue #2571.
Uploader: Roland Schulz ()
Change-Id: gromacs~master~Ibae0b68e30fdcdc5f57cb6ff7c5b78a44df3fb01
Gerrit URL: https://gerrit.gromacs.org/8081

#2 Updated by Mark Abraham 6 days ago

  • Status changed from New to Resolved
  • Assignee set to Roland Schulz

#3 Updated by Mark Abraham 6 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF