Bug #2664
gmxapi tests using gmx to make a .tpr needs to be quieter
Description
In order to avoid bundling a .tpr file that is needed for testing, gmxapi is using the gmx target to run grompp at build time. This means that in cmake -DGMX_DEVELOPER_BUILD=on
that a make all
runs gmx grompp
and that writes to the terminal. I think we should not output to the terminal from make unless there's a problem.
So, we could at least run gmx -quiet grompp
. But preferably catch the terminal output and throw it away. Alternatively, work out how to call grompp as part of the test.
We should probably also not build the API tests when the cmake CROSSCOMPILING variable is true, because we can't run gmx then, either.
Related issues
Associated revisions
Rework GMXAPI tests
Changed the tests to use a test fixture and only generate the tpr files
during the actual tests.
Fixes #2664
Change-Id: Ic8a0c1c5eed2189abb9006cb45097d1acd41d175
History
#1 Updated by Paul Bauer over 2 years ago
- Assignee set to Paul Bauer
I can try to hack something there to look more like the tests for topologyinformation.
#2 Updated by Gerrit Code Review Bot over 2 years ago
Gerrit received a related patchset '1' for Issue #2664.
Uploader: Paul Bauer (paul.bauer.q@gmail.com)
Change-Id: gromacs~master~Ic8a0c1c5eed2189abb9006cb45097d1acd41d175
Gerrit URL: https://gerrit.gromacs.org/8483
#3 Updated by Mark Abraham over 2 years ago
- Status changed from New to Fix uploaded
#4 Updated by Gerrit Code Review Bot over 2 years ago
Gerrit received a related patchset '2' for Issue #2664.
Uploader: M. Eric Irrgang (ericirrgang@gmail.com)
Change-Id: gromacs~master~If581edb4e129e75cf40e468a6060b253b4951091
Gerrit URL: https://gerrit.gromacs.org/8544
#5 Updated by Mark Abraham over 2 years ago
- Status changed from Fix uploaded to Accepted
Temporary fix suppressing output is incorporated, but we should seek a better approach later
#6 Updated by Eric Irrgang over 2 years ago
- Status changed from Accepted to Resolved
Applied in changeset e9b284a2836f01bdb4899dd8b27ba8d208e9458c.
#7 Updated by Mark Abraham about 2 years ago
- Related to Bug #2669: GMXAPI can not be build when crosscompiling added
#8 Updated by Gerrit Code Review Bot about 2 years ago
Gerrit received a related patchset '1' for Issue #2664.
Uploader: Paul Bauer (paul.bauer.q@gmail.com)
Change-Id: gromacs~release-2019~Ic8a0c1c5eed2189abb9006cb45097d1acd41d175
Gerrit URL: https://gerrit.gromacs.org/8662
#9 Updated by Paul Bauer about 2 years ago
Applied in changeset 590260fa91b622bc742da392b744ea28ff34a7fe.
#10 Updated by Paul Bauer about 2 years ago
- Status changed from Resolved to Closed
Clean up gmxapi testsupport output.
Silence grompp during CMake preparation of gmxapi test input data. Make
some notes that a better long term solution is necessary.
Fixes #2664
Change-Id: If581edb4e129e75cf40e468a6060b253b4951091