Project

General

Profile

Bug #2664

gmxapi tests using gmx to make a .tpr needs to be quieter

Added by Mark Abraham 9 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Low
Assignee:
Paul Bauer
Category:
testing
Target version:
2019
Affected version - extra info:
Affected version:
git master
Difficulty:
uncategorized
Close

Description

In order to avoid bundling a .tpr file that is needed for testing, gmxapi is using the gmx target to run grompp at build time. This means that in cmake -DGMX_DEVELOPER_BUILD=on that a make all runs gmx grompp and that writes to the terminal. I think we should not output to the terminal from make unless there's a problem.

So, we could at least run gmx -quiet grompp. But preferably catch the terminal output and throw it away. Alternatively, work out how to call grompp as part of the test.

We should probably also not build the API tests when the cmake CROSSCOMPILING variable is true, because we can't run gmx then, either.

Related issues

Related to GROMACS - Bug #2669: GMXAPI can not be build when crosscompilingClosed

Associated revisions

Revision e9b284a2 (diff)
Added by Eric Irrgang 8 months ago

Clean up gmxapi testsupport output.

Silence grompp during CMake preparation of gmxapi test input data. Make
some notes that a better long term solution is necessary.

Fixes #2664

Change-Id: If581edb4e129e75cf40e468a6060b253b4951091

Revision 590260fa (diff)
Added by Paul Bauer 7 months ago

Rework GMXAPI tests

Changed the tests to use a test fixture and only generate the tpr files
during the actual tests.

Fixes #2664

Change-Id: Ic8a0c1c5eed2189abb9006cb45097d1acd41d175

History

#1 Updated by Paul Bauer 9 months ago

  • Assignee set to Paul Bauer

I can try to hack something there to look more like the tests for topologyinformation.

#2 Updated by Gerrit Code Review Bot 9 months ago

Gerrit received a related patchset '1' for Issue #2664.
Uploader: Paul Bauer ()
Change-Id: gromacs~master~Ic8a0c1c5eed2189abb9006cb45097d1acd41d175
Gerrit URL: https://gerrit.gromacs.org/8483

#3 Updated by Mark Abraham 9 months ago

  • Status changed from New to Fix uploaded

#4 Updated by Gerrit Code Review Bot 8 months ago

Gerrit received a related patchset '2' for Issue #2664.
Uploader: M. Eric Irrgang ()
Change-Id: gromacs~master~If581edb4e129e75cf40e468a6060b253b4951091
Gerrit URL: https://gerrit.gromacs.org/8544

#5 Updated by Mark Abraham 8 months ago

  • Status changed from Fix uploaded to Accepted

Temporary fix suppressing output is incorporated, but we should seek a better approach later

#6 Updated by Eric Irrgang 8 months ago

  • Status changed from Accepted to Resolved

#7 Updated by Mark Abraham 8 months ago

  • Related to Bug #2669: GMXAPI can not be build when crosscompiling added

#8 Updated by Gerrit Code Review Bot 8 months ago

Gerrit received a related patchset '1' for Issue #2664.
Uploader: Paul Bauer ()
Change-Id: gromacs~release-2019~Ic8a0c1c5eed2189abb9006cb45097d1acd41d175
Gerrit URL: https://gerrit.gromacs.org/8662

#9 Updated by Paul Bauer 7 months ago

#10 Updated by Paul Bauer 7 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF