Project

General

Profile

Task #2729

gmxapi tests should not depend on command line tools

Added by Eric Irrgang 3 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
api
Target version:
-
Difficulty:
uncategorized
Close

Description

gmxapi tests use grompp to prepare test simulation input since equivalent functionality is not available in the public API in GROMACS 2019.

This means that the gmxapi tests cannot be configured when cross-compiling (see #2669), so a fatal error is issued when both GMXAPI and BUILD_TESTING are ON if the CMAKE_CROSSCOMPILING variable is set (such as due to explicitly setting CMAKE_SYSTEM_NAME).

This issue could be resolved using existing testing framework utilities, as in https://gerrit.gromacs.org/c/8483/ , or by migrating to API features for simulation preparation, as they become available.

In either case, when gmxapi tests no longer rely on grompp, the fatal error issued by CMake should be removed.


Related issues

Related to GROMACS - Bug #2669: GMXAPI can not be build when crosscompilingClosed

History

#1 Updated by Eric Irrgang 3 months ago

  • Related to Bug #2669: GMXAPI can not be build when crosscompiling added

#2 Updated by Gerrit Code Review Bot 3 months ago

Gerrit received a related patchset '1' for Issue #2729.
Uploader: M. Eric Irrgang ()
Change-Id: gromacs~release-2019~I390d1128731f574d90489fd77b0c255dfec7f80d
Gerrit URL: https://gerrit.gromacs.org/8644

#3 Updated by Eric Irrgang 2 months ago

  • Status changed from New to Resolved

Resolved in Change-Id: Ic8a0c1c5eed2189abb9006cb45097d1acd41d175

#4 Updated by Paul Bauer about 1 month ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF