Project

General

Profile

Bug #2811

CUDA binary target support check can't work

Added by Szilárd Páll 9 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
mdrun
Target version:
Affected version - extra info:
2018
Affected version:
Difficulty:
uncategorized
Close

Description

The check that verifies whether mdrun includes code that can run on the detected, but otherwise supported GPU has been ineffective as it is called at gpu_init() time while the sanity checker dummy kernel will already fail to launch earlier when mdrun doesn't have code to run on the device.

checkCompiledTargetCompatibility() should clearly be called earlier.


Related issues

Related to GROMACS - Bug #2810: running on Fermi throws cryptic errorClosed

Associated revisions

Revision d53b7788 (diff)
Added by Szilárd Páll 9 months ago

Fix CUDA compiled target-device compatibility check

The check that should catch cases where the binary does not contain
suitable code for the otherwise supported GPU architecture was
erroneously called from the initialization which is too late to
actually trigger it as the error that is meant to prevent will be
already triggered when the sanity checker tries to launch the dummy
kernel.
This change moves the check in question into the sanity checking and
keeps the fatal error as this is a rare condition that's unexpected
and typically a result of a misconfiguration at GROMACS build time.

Fixes #2811

Change-Id: I3762f51077a7c7c80b533860758bbab385b8a1fe

History

#1 Updated by Szilárd Páll 9 months ago

  • Related to Bug #2810: running on Fermi throws cryptic error added

#2 Updated by Gerrit Code Review Bot 9 months ago

Gerrit received a related patchset '1' for Issue #2811.
Uploader: Szilárd Páll ()
Change-Id: gromacs~release-2019~I3762f51077a7c7c80b533860758bbab385b8a1fe
Gerrit URL: https://gerrit.gromacs.org/8845

#3 Updated by Szilárd Páll 9 months ago

  • Status changed from New to Fix uploaded

#4 Updated by Szilárd Páll 9 months ago

  • Target version set to 2019

#5 Updated by Szilárd Páll 9 months ago

  • Status changed from Fix uploaded to Resolved

#6 Updated by Paul Bauer 9 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF