Project

General

Profile

Feature #2816

Device-side update&constraits, buffer ops and multi-gpu comms

Added by Alan Gray 3 months ago. Updated 3 days ago.

Status:
New
Priority:
Normal
Assignee:
Category:
mdrun
Target version:
Difficulty:
hard
Close

Description

Gromacs is sub-optimal on modern GPU Servers.

When running on a single GPU, all force calculations are now done on the device, but the buffer operations plus update & constraints are done on the host, and repeated PCI-e transfers are required. Such CPU computation and PCI-e communication comprise an increasingly significant overhead as the performance of the GPU continues to increase with each subsequent generation.

On multi-GPU the situation is ever worse because the required multi-GPU communications are routed through the CPU.

NVIDIA have developed prototype code with all compute and communication parts now device-side, with coordinate and force PCIe transfers removed for regular timesteps. Gerrit patch 8506 introduces device-side buffer ops, and patch 8859 (based on the buffer ops patch) demonstrates the remainder of the new developments:

  • GPU Update and Constraints
  • Device MPI: PME/PP Gather and Scatter
    - Relatively straightforward solution using CUDA-Aware MPI
  • Device MPI: PP local/nonlocal exchanges
    - New functionality to pack device-buffers and exchange using CUDA-aware MPI
    - Similar D2D exchanges also for Constraints Lincs part

See the attached slides for more info.

These developments show major performance improvements, but are still in prototype form, and the purpose of this issue is to track the work required to integrate properly into the master branch.

NVDevUpdate21Dec18.pdf (1.21 MB) NVDevUpdate21Dec18.pdf Slides describing NVIDIA developments Alan Gray, 12/21/2018 11:15 AM

Subtasks

Feature #2817: GPU X/F buffer opsAccepted
Feature #2885: CUDA version of LINCSNewArtem Zhmurov
Feature #2886: CUDA version of SETTLENewArtem Zhmurov
Feature #2887: CUDA version of Leap Frog algorithmNewArtem Zhmurov
Feature #2888: CUDA Update and Constraints moduleNewArtem Zhmurov
Feature #2890: GPU Halo ExchangeNew
Feature #2891: PME/PP GPU communications New

Associated revisions

Revision bec0fa7b (diff)
Added by Artem Zhmurov about 1 month ago

Test for LINCS and SHAKE constraints.

This version updates the tests making the selection of the
constraining algorithm more abstract. Makes it possible
to use the same test routines for new implementations (e.g.
CPU- or GPU-based) or (and) algorithms (e.g. LINCS or SHAKE).
Partly this is preparation for the GPU-based version of
the constraints (Refs #2816).

Change-Id: Ice7dfdcc6d86c04656b0a1dd4e328c5afdb8a263

History

#1 Updated by Gerrit Code Review Bot about 1 month ago

Gerrit received a related patchset '26' for Issue #2816.
Uploader: Artem Zhmurov ()
Change-Id: gromacs~master~Ice7dfdcc6d86c04656b0a1dd4e328c5afdb8a263
Gerrit URL: https://gerrit.gromacs.org/8982

#2 Updated by Gerrit Code Review Bot about 1 month ago

Gerrit received a related DRAFT patchset '1' for Issue #2816.
Uploader: Artem Zhmurov ()
Change-Id: gromacs~master~I3c975cf898053b7467bcd30459e60ce2c8852be6
Gerrit URL: https://gerrit.gromacs.org/9193

#3 Updated by Alan Gray 27 days ago

I want to add a subtask here for "GPU Halo exchange", but can't see a way to do it. Are special permissions required?

#4 Updated by Gerrit Code Review Bot 27 days ago

Gerrit received a related patchset '2' for Issue #2816.
Uploader: Alan Gray ()
Change-Id: gromacs~master~I8e6473481ad4d943df78d7019681bfa821bd5798
Gerrit URL: https://gerrit.gromacs.org/9225

#5 Updated by Gerrit Code Review Bot 26 days ago

Gerrit received a related DRAFT patchset '1' for Issue #2816.
Uploader: Artem Zhmurov ()
Change-Id: gromacs~master~I218e1bf1f86a2351e189e3c27f950f45c06135a4
Gerrit URL: https://gerrit.gromacs.org/9244

#6 Updated by Gerrit Code Review Bot 18 days ago

Gerrit received a related DRAFT patchset '4' for Issue #2816.
Uploader: Artem Zhmurov ()
Change-Id: gromacs~master~I439d7f5fd4f69a17ca7aaa412e242ce5e3aa5dbd
Gerrit URL: https://gerrit.gromacs.org/9272

#7 Updated by Szilárd Páll 17 days ago

We need to decouple these changes; there are several distinct features that are proposed here, so we need redmine issues for those. I would also prefer to organize trees of issues around a certain target feature-set, e.g. single-GPU no-DD all offloaded, or multi-GPU with-DD, most offloaded, etc. While feature sets may overlap, the higher-level features are these parallelization functionalities that will depend/be related to both common and individual tasks.
Consequently, at least a separate LINCS, SETTLE, Update, halo exchange, and PP-PME comm issues would be desirable, possibly even separate ones for with/without communication (when this makes sense).

#8 Updated by Alan Gray 17 days ago

Yes. I already tried to create a sub-task here for halo exchange, but couldn't see how to do it. Could you let me know how you did it for the "GPU X/F Buffer Ops" task? It may be a permissions thing.

#9 Updated by Artem Zhmurov 17 days ago

I've created blank features for the GPU-only loop. Will start filling them up .

#10 Updated by Gerrit Code Review Bot 4 days ago

Gerrit received a related patchset '4' for Issue #2816.
Uploader: Artem Zhmurov ()
Change-Id: gromacs~master~I8730aad0ecaa0230686fe89d1157b0da2f01f7bc
Gerrit URL: https://gerrit.gromacs.org/9329

#11 Updated by Gerrit Code Review Bot 3 days ago

Gerrit received a related DRAFT patchset '2' for Issue #2816.
Uploader: Artem Zhmurov ()
Change-Id: gromacs~master~I4c65a6c7088fd8059f4e7fa3cb4637cb2af79ebc
Gerrit URL: https://gerrit.gromacs.org/9349

Also available in: Atom PDF