Project

General

Profile

Bug #2832

PaddedVector move operations broken

Added by Mark Abraham about 1 month ago. Updated 9 days ago.

Status:
New
Priority:
Low
Assignee:
Category:
core library
Target version:
Affected version - extra info:
Affected version:
Difficulty:
uncategorized
Close

Description

While reviewing https://gerrit.gromacs.org/#/c/8919/ I realised that there is not enough test coverage of move construction, move assignment for PaddedVector.

I am not yet sure whether it is best to remove them (because untested) or add tests and fix the implementation. It is reasonable to just depend on the copies, but I'm not sure we're usingn them in release-2019 branch, either.

History

#1 Updated by Mark Abraham 24 days ago

I have some WIP on master, but still need to decide what makes sense to backport to release, or just disable

#2 Updated by Mark Abraham 9 days ago

  • Target version changed from 2019.1 to 2020

The single-argument move constructor isn't working, and I suspect aspects of the two-argument move constructor can be improved. But I haven't been able to write test code that 2019 fails, so we can reconsider the implementation and tests for 2020.

Also available in: Atom PDF