Project

General

Profile

Bug #3111

Task #3132: gmxapi testing support tools

sample_restraint testing should not download files

Added by Mark Abraham about 2 months ago. Updated 20 days ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
testing
Target version:
Affected version - extra info:
Affected version:
Difficulty:
uncategorized
Close

Description

In a build directory where I had previously set GMXAPI=on and PYTHON_PACKAGING=on, I touched some src/api .cpp files while offline, and when I reran cmake I saw

[mark-XPS review (updated-commrec-dependency-removal)] $ (cd build-cmake-clang-debug; ninja mdrun-mpi-test && bin/mdrun-mpi-test -ntmpi 4 --gtest_filter=MinimizersWorkWithConstraints/EnergyMinimizationTest.WithinTolerances/1)
[0/2] Re-checking globbed directories...
[1/2] Re-running CMake...
-- pybind11 v2.2.4
-- Found Python interpreter: /usr/bin/python3
-- Python site-packages directory is /usr/lib/python3.6/site-packages
-- Python module will be installed to GMXPLUGIN_INSTALL_PATH cache value /usr/lib/python3.6/site-packages
CMake Warning at python_packaging/sample_restraint/tests/CMakeLists.txt:62 (message):
  Could not download test data: getaddrinfo(3) failed for github.com:443

  Couldn't resolve host 'github.com'

  Closing connection 0

-- Configuring done
-- Generating done
-- Build files have been written to: /home/mabraham/git/review/build-cmake-clang-debug

The sample_restraint testing should not be downloading a .tpr file (or whatever it is doing). I can see in my source directory a python_packaging/sample_restraint/tests/topol.tpr which should not be there. If we need a .tpr, then we should make one by calling grompp.


Related issues

Related to GROMACS - Feature #2961: How should Python package find GROMACS resources under various circumstances?New
Related to GROMACS - Task #3027: Move sample_restraint development from GitHub to GerritIn Progress
Related to GROMACS - Task #2756: gmxapi integration testingIn Progress
Related to GROMACS - Task #3133: Cookiecutter for sample_restraintNew

Associated revisions

Revision 984907ad (diff)
Added by Eric Irrgang 21 days ago

Disable its tests when sample_restraint is not the master project.

Avoids some distracting CMake output for GROMACS builds, and avoids
trying to download a test input file.

Fixes #3111

Change-Id: I53f4d88184a5112a430a051c086ffa864b0eeb41

History

#1 Updated by Eric Irrgang about 1 month ago

  • Related to Feature #2961: How should Python package find GROMACS resources under various circumstances? added

#2 Updated by Eric Irrgang about 1 month ago

  • Related to Task #3027: Move sample_restraint development from GitHub to Gerrit added

#3 Updated by Eric Irrgang about 1 month ago

  • Related to Task #2756: gmxapi integration testing added

#4 Updated by Eric Irrgang about 1 month ago

Note that this only occurs if both BUILD_TESTING and GMX_PYTHON_PACKAGE are set, so the workaround is to build documentation with GMX_PYTHON_PACKAGE=ON and BUILD_TESTING OFF.

I will create a couple of new issues regarding improved sample_restraint integration testing and more unified test support tools. For this particular case, it might be reasonable to make the gmxapi Python package a dependency for all of the sample_restraint tests and to use it to create the test input file, even for the C++ unit tests.

#5 Updated by Eric Irrgang about 1 month ago

  • Parent task set to #3132

#6 Updated by Eric Irrgang about 1 month ago

  • Related to Task #3133: Cookiecutter for sample_restraint added

#7 Updated by Eric Irrgang about 1 month ago

  • Status changed from New to Fix uploaded

#8 Updated by Eric Irrgang 21 days ago

  • Status changed from Fix uploaded to Resolved

#9 Updated by Paul Bauer 20 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF