Project

General

Profile

Bug #3281

Test data directory GMX_RELEASE_ASSERT triggers

Added by Erik Lindahl 6 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Affected version - extra info:
Affected version:
Difficulty:
uncategorized
Close

Description

When downloading an artefact from GitLab and trying to run simd-test (which does not read any input files), I get an assert triggered by line 257 of src/testutils/testfilemanager.cpp.

1) First, we should only use asserts for internal code correctness checks, never for anything that can be user-triggered, so any check if a particular directory is present should be replaced with a more user-friendly explicit error message.

2) It seems bad that we are checking the existence of a directory that will never be used by many tests. IMHO, we should only produce an error when an actual file we need is not present.

Now, the main reason for this is that it complicates debugging :-) At least in theory it's an awesome feature to be able to download just the build artefacts and reproduce a failure - but much of that is lost if I first need to recreate an exact copy of the build image as well as all source and data directories...

Also available in: Atom PDF