Project

General

Profile

Bug #474

threads linking

Added by Christoph Junghans over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
mdrun
Target version:
Affected version - extra info:
Affected version:
Difficulty:
uncategorized
Close

Description

Created an attachment (id=497)
patch to fix overlinking of pthreads for autotools

I fixed the pkg-config files to work with threads again and I removed pthread_libs from libs to avoid future overlinking.

A patch for cmake will follow soon.

threads_overlinking_autotools.patch (4 KB) threads_overlinking_autotools.patch patch to fix overlinking of pthreads for autotools Christoph Junghans, 07/21/2010 01:10 PM

Related issues

Blocked by GROMACS - Bug #473: xml overlinkingClosed07/21/2010
Blocks GROMACS - Bug #370: install pkg-config file for better linkingClosed11/15/2009

History

#1 Updated by Sander Pronk over 9 years ago

Thanks, I hadn't thought about 3d party linking issues by double linking libraries. Which platforms give problems without this patch?

#2 Updated by Christoph Junghans over 9 years ago

This is a problem on all platforms due to the fact that you never know with what
thread flags/libs gromacs was compiled.
So if there are two thread implementations on your system you will have to guess which one gromacs has used to link against any gromacs lib ;-)

Actually libgmxana does not even depend on threads directly, which is overlinking. However as libgmxana depends on libmd is does not matter in this case. That is why the threads flags are still in libgmxana.pc.in

This bug is the last patch of a series of four (bug #471-#474) to get the LIBS variable split.

#3 Updated by Christoph Junghans over 9 years ago

fixed in commit d065359caf79caaa80720a1a05b9efe112644eef by Sander

Also available in: Atom PDF