Project

General

Profile

Bug #485

need to move GMX_DISABLE_GCC41_CHECK earlier in CMakeLists.txt to allow override

Added by Peter Kasson over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Erik Lindahl
Category:
mdrun
Target version:
Affected version - extra info:
Affected version:
Difficulty:
uncategorized
Close

Description

I'd commit this myself, but I wanted to get someone else's eyes on it...
Right now, if you want to override the gcc 4.1.x check with CMake, it doesn't let you because it hits the version check before the option is enabled. Moving the line
option(GMX_DISABLE_GCC41_CHECK "Disable check for (buggy) gcc 4.1.x" OFF)
to right before the version check in CMakeLists.txt fixes this.

Diff is as follows:
diff --git a/CMakeLists.txt b/CMakeLists.txt
index b794d15..44249d4 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@ -37,6 +37,7 @ set(GMX_EXTRA_LIBRARIES)
include(CheckCCompilerFlag)
include(CheckCXXCompilerFlag)

+option(GMX_DISABLE_GCC41_CHECK "Disable check for (buggy) gcc 4.1.x" OFF) # check for buggy GCC 4.1.x
include(gmxCheckGCCVersion)

@ -71,7 +72,6 @ mark_as_advanced(GMX_MPI_IN_PLACE)
option(GMX_IA32_ASM "Add SSE assembly files for IA32" OFF)
option(GMX_X86_64_ASM "Add SSE assembly files for X86_64" OFF)
option(USE_VERSION_H "Generate development version string/information" ON)
-option(GMX_DISABLE_GCC41_CHECK "Disable check for (buggy) gcc 4.1.x" OFF)

set(GMX_BINARY_SUFFIX "" CACHE STRING "Suffix for GROMACS binaries.")

History

#1 Updated by Szilárd Páll over 9 years ago

Actually the check is now removed (commit 1b68a93) as it turned out that the earlier crash (see bug report 431)for which we blamed gcc 4.1.x was a bug in the GB code.

#2 Updated by Szilárd Páll over 9 years ago

Forgot to mark fixed.

Also available in: Atom PDF