Project

General

Profile

Task #673

Reorganize code from src/ngmx/

Added by Teemu Murtola over 6 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Category:
build system
Target version:
Difficulty:
uncategorized
Close

Description

Move code for programs that are built from src/ngmx/ into separate subdirectories under src/programs/ and update CMake files accordingly. It remains to be decided where code used in multiple programs should go. There is also some dead code in the directory (e.g., g_highway.c) that should be cleaned up.

Associated revisions

Revision ff0af6b2 (diff)
Added by Teemu Murtola almost 4 years ago

Remove g_highway and vbox.c.

g_highway hasn't been included in the build for a long time (never for
CMake), so I don't think anyone will miss it. No need to keep it up to
date with changes done in program initialization for the wrapper binary.

vbox.c seems unused.

There are some other source files under src/ngmx/ that contain a main()
and are not included in the current build, but those seem some kind of
test programs, and don't seem to use much outside src/ngmx/, so left
them alone for now.

Related to #673.

Change-Id: I8b24f58450969e432dff677b8a9659e7bc544e00

Revision 3beddf1e (diff)
Added by David van der Spoel over 3 years ago

Moved ngmx to C++, renamed it to view.

Part of #673
Moved all files to src/programs/view and made executable
part of the gmx binary as "gmx view".
Removed warnings.
Replacing min and max by std::min and std::max.
Removed warning in asize macro.
Changed typedef enums to C++ enums.
Changed gmx_bool to bool.
Removed g_showcol, g_xrama, xstat, test_ngmx_dialog

Change-Id: I88fc541e27705c498703006f461dd2b9b1e6a3f5

History

#1 Updated by Teemu Murtola over 3 years ago

  • Status changed from New to Fix uploaded
  • Assignee set to David van der Spoel
  • Target version set to 5.0

Done in https://gerrit.gromacs.org/#/c/2581/. What remains is making ngmx part of the wrapper binary, but that is not exactly part of this issue.

#2 Updated by Teemu Murtola over 3 years ago

  • Status changed from Fix uploaded to Resolved

Also the wrapper binary part done in the linked commit.

#3 Updated by Rossen Apostolov over 3 years ago

  • Status changed from Resolved to Closed

#4 Updated by Teemu Murtola over 3 years ago

  • Project changed from Source code reorganization to GROMACS
  • Category set to build system

Also available in: Atom PDF