Bug #752
With PD, non-master processes allocate state twice
Affected version - extra info:
all 4.x
Affected version:
Difficulty:
uncategorized
Description
In release-4-5-patches in mdrunner(), the state is always allocated with snew upon entry to mdrunner() - see http://redmine.gromacs.org/projects/gromacs/repository/revisions/release-4-5-patches/entry/src/kernel/runner.c#L385.
However, about line 652 of mdrunner.c (see http://redmine.gromacs.org/projects/gromacs/repository/revisions/release-4-5-patches/entry/src/kernel/runner.c#L652), for PP nodes that are not under DD, that are in parallel and not the master, state is again allocated with snew. This either leaks memory, or loses useful data, or both.
Assigned to Berk, because I think he introduced this in 2008 in commit 50469af3.
Associated revisions
History
#1 Updated by Berk Hess about 9 years ago
- Status changed from New to Closed
This was only a memory leak. I fixed it by removing the second snew.
fixed minor memory leak with particle decomposition, fixes #752