Bug #998
MSVC AVX flag check isn't working
Description
Running cmake 2.8.9 with VC2010 without a preexisting CMakeCache.txt file gives "No C AVX flag found.". If one deletes MSVC_AVX_CFLAG from the cache (otherwise the test isn't rerun) then on the 2nd run the flag is found correctly. I don't have an idea why the GMX_TEST_CFLAG would work on the 2nd run but not the first.
Associated revisions
History
#1 Updated by Szilárd Páll over 8 years ago
- Category set to build system
Erik, do you have any idea why does this happen?
#2 Updated by Roland Schulz over 8 years ago
- Assignee set to Roland Schulz
#3 Updated by Roland Schulz over 8 years ago
- Status changed from New to In Progress
#4 Updated by Szilárd Páll about 8 years ago
Roland, have you checked whether ec013903 really fixed the actual issue? I'm asking just because the commit message doesn't explicitly mention mention that it fixes an MSVC+AVX issue.
#5 Updated by Roland Schulz about 8 years ago
- Status changed from In Progress to Closed
Yes. The AVX is just what I noticed. All compile checks were broken after the isfinite check.
Fix usage of CMAKE_REQUIRED_*
Always reset all variables.
Only require libm if it is avaiable (only on Unix)
Also prefer usage of _finite. ICC on Windows gives warnings
for isfinite (we don't inlude mathimf.h).
Fixes #998
Change-Id: Ib7c064aaf6d26d2ab96f5e88345091a2eb096998