Project

General

Profile

Bug #1152

parse_n_real out of bounds

Added by Christoph Junghans about 7 years ago. Updated almost 7 years ago.

Status:
Rejected
Priority:
Low
Category:
mdrun
Target version:
-
Affected version - extra info:
8d6cc14646cd519f0fe4f718cece1ac00d4fa842
Affected version:
Difficulty:
uncategorized
Close

Description

gcc (GCC) 4.3.0 20080428 (Red Hat 4.3.0-8) tells me:
[ 80%] /home/junghans/opt/src/gromacs-8d6cc14646cd519f0fe4f718cece1ac00d4fa842/src/kernel/readir.c: In function ‘get_ir’:
/home/junghans/opt/src/gromacs-8d6cc14646cd519f0fe4f718cece1ac00d4fa842/src/kernel/readir.c:1368: warning: array subscript is above array bounds
/home/junghans/opt/src/gromacs-8d6cc14646cd519f0fe4f718cece1ac00d4fa842/src/kernel/readir.c:1368: warning: array subscript is above array bounds
/home/junghans/opt/src/gromacs-8d6cc14646cd519f0fe4f718cece1ac00d4fa842/src/kernel/readir.c:1368: warning: array subscript is above array bounds
/home/junghans/opt/src/gromacs-8d6cc14646cd519f0fe4f718cece1ac00d4fa842/src/kernel/readir.c:1368: warning: array subscript is above array bounds
/home/junghans/opt/src/gromacs-8d6cc14646cd519f0fe4f718cece1ac00d4fa842/src/kernel/readir.c:1368: warning: array subscript is above array bounds

The affected part of the code is:
for (i = 0; i < efptNR; i++) {
parse_n_real(fep_lambda[i], &(nfep[i]), &(count_fep_lambdas[i]));
}
so it is FEP stuff.

History

#1 Updated by Mark Abraham almost 7 years ago

  • Status changed from New to Rejected
  • Priority changed from Normal to Low
  • Target version deleted (4.6.2)
  • Affected version set to 4.6.1

Our Jenkins config with a more recent 4.3-series gcc does not give warnings. The code clearly allocates all of those arrays with dimension efptNR. So I think this is warning is either overzealous or based on an incomplete gcc 4.3.0 implementation that has since been corrected.

Also available in: Atom PDF