Project

General

Profile

Task #1211

improve use of preprocessor macros in CUDA kernels

Added by Szilárd Páll over 6 years ago. Updated almost 5 years ago.

Status:
New
Priority:
Low
Category:
mdrun
Target version:
Difficulty:
uncategorized
Close

Description

With extensions and optimizations gradually added to the CUDA kernels the code became quite hard to read doe to the following aspects:
- poorly documented #ifdef's (especially no comment mark at closing #endif's
- use of catch-all #else
- use of #if X..#endif #if Y..#endif instead of #if X #elif Y #endif when X and Y are anyway mutually exclusive.

More concrete comments are on the gerrit page of change 2232.


Related issues

Related to GROMACS - Feature #1666: new approach for Verlet-scheme kernel generationNew

History

#1 Updated by Mark Abraham over 6 years ago

Thanks, good idea to note the future task

#2 Updated by Mark Abraham almost 5 years ago

  • Related to Feature #1666: new approach for Verlet-scheme kernel generation added

#3 Updated by Mark Abraham almost 5 years ago

  • Description updated (diff)

#4 Updated by Szilárd Páll almost 5 years ago

  • Description updated (diff)

Also available in: Atom PDF