Project

General

Profile

Task #1644

eliminate md_print_info/warn code-duplication

Added by Szilárd Páll over 4 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
core library
Target version:
Difficulty:
uncategorized
Close

Description

md_print_info() and md_print_warn() have been duplicated in the CUDA GPU modules in order to avoid implicitly including "mpi.h". The problematic header dependencies have been eliminated, so the code duplication should also be removed.

Associated revisions

Revision 20bbcb75 (diff)
Added by Teemu Murtola about 3 years ago

Use C++ replacement for md_logging.*

Replace md_logging.h with the new C++ implementation. This removes the
need to pass around a (FILE *, t_commrec *) tuple for just calling
md_logging.h routines. Initialize the logger in runner.cpp to get the
same output as earlier. For now, output is the same as earlier, but the
new interface could also relatively easily support, e.g., automatic line
wrapping.

Further changes should see all of fplog access go through the same
object (possibly after finetuning the interface), but that would be too
large of a change to do in one go.

Thread affinity tests for now just discard the log output, making them
more silent. Future changes should see the log output verified, to
check that the correct messages are produced.

Related to #1505, closes #1644.

Change-Id: I0895b752b040d231cacb49a3a7a48d26c6096944

History

#1 Updated by Gerrit Code Review Bot about 4 years ago

Gerrit received a related patchset '1' for Issue #1644.
Uploader: Szilárd Páll ()
Change-Id: Id51e3b7e487b80843ce56a3f38cde702743ab2f5
Gerrit URL: https://gerrit.gromacs.org/4812

#2 Updated by Szilárd Páll about 4 years ago

  • Status changed from New to In Progress

#3 Updated by Gerrit Code Review Bot over 3 years ago

Gerrit received a related patchset '1' for Issue #1644.
Uploader: Teemu Murtola ()
Change-Id: I0895b752b040d231cacb49a3a7a48d26c6096944
Gerrit URL: https://gerrit.gromacs.org/5449

#4 Updated by Teemu Murtola about 3 years ago

  • Status changed from In Progress to Fix uploaded
  • Assignee changed from Szilárd Páll to Teemu Murtola
  • Target version changed from 5.x to 2018

#5 Updated by Teemu Murtola about 3 years ago

  • Status changed from Fix uploaded to Resolved

#6 Updated by Teemu Murtola about 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF