Project

General

Profile

Bug #1722

gromacs/gmxpreprocess/readir.c:2436: bad if statement ?

Added by David Binderman over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
preprocessing (pdb2gmx,grompp)
Target version:
Affected version - extra info:
5.0.4
Affected version:
Difficulty:
uncategorized
Close

Description

gromacs/gmxpreprocess/readir.c:2436:49: warning: logical 'and' of mutually exclusive tests is always false [-Wlogical-op]

            ((opts->couple_lam0 == ecouplamVDW  && opts->couple_lam0 == ecouplamVDWQ) ||
             (opts->couple_lam1 == ecouplamVDWQ && opts->couple_lam1 == ecouplamVDW)))

Associated revisions

Revision b89ea581 (diff)
Added by Mark Abraham over 4 years ago

Update reference warnings for new grompp check

The simple FE setup is one that we think is used often, and there the
warning is useful, and the test setups invoke such a setup, so we may
as well ensure that the tests check that that warning works.

Refs #1421, #1722

Change-Id: I0d974b50db4a4e0986815ec6c4064e3c4738e0ef

Revision 7d62d8f6 (diff)
Added by Mark Abraham over 4 years ago

Fixed recently-introduced couple-lambda warning message

The grompp warning was not issued correctly. Any simulation that ran
was unaffected.

Refs #1421
Fixes #1722

Change-Id: Ib582d3749c283dbb03504c5ec09f854c518e11a5

History

#1 Updated by Gerrit Code Review Bot over 4 years ago

Gerrit received a related patchset '1' for Issue #1722.
Uploader: Mark Abraham ()
Change-Id: Ib582d3749c283dbb03504c5ec09f854c518e11a5
Gerrit URL: https://gerrit.gromacs.org/4542

#2 Updated by Mark Abraham over 4 years ago

  • Description updated (diff)
  • Category set to preprocessing (pdb2gmx,grompp)
  • Assignee set to Mark Abraham
  • Target version set to 5.0.5
  • Affected version - extra info set to 5.0.4
  • Affected version changed from git master to 5.0.3

#3 Updated by Mark Abraham over 4 years ago

Thanks for the report, the logic of that check was indeed wrong!

#4 Updated by Gerrit Code Review Bot over 4 years ago

Gerrit received a related patchset '1' for Issue #1722.
Uploader: Mark Abraham ()
Change-Id: I0d974b50db4a4e0986815ec6c4064e3c4738e0ef
Gerrit URL: https://gerrit.gromacs.org/4543

#5 Updated by Mark Abraham over 4 years ago

  • Status changed from New to Closed

Also available in: Atom PDF