Project

General

Profile

Bug #1835

NVML support can't be disabled in the build system

Added by Szilárd Páll over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
build system
Target version:
Affected version - extra info:
Affected version:
Difficulty:
uncategorized
Close

Description

If the user wants to disable NVML support (even though all dependencies are found by CMake), this is not possible without editing the cache manually.

ref: https://mailman-1.sys.kth.se/pipermail/gromacs.org_gmx-users/2015-October/101144.html


Related issues

Related to GROMACS - Bug #1838: Error building gromacs-5.1 with NVML supportClosed

Associated revisions

Revision 8b14e14f (diff)
Added by Mark Abraham about 4 years ago

Allowed NVML support to be toggled

A new CMake advanced option GMX_USE_NVML takes its default value from
the result of the NVML detection, thus by default NVML support is on
only if the detection succeeds. It can be turned off or on at will,
but when set on, it will give a fatal error if the detection did not
succeed.

Split the NVML section of the install guide into its own paragraph.

Fixes #1835

Change-Id: Ic1bf025fcd807eb701d0b52afe35b11b2d75f402

Revision 3309a559 (diff)
Added by Mark Abraham about 4 years ago

Fix default for GMX_USE_NVML

NVML_FOUND is the result of the detection, which should
be the default for GMX_USE_NVML.

Refs #1835

Change-Id: I0fd640d4c431242e47e147bd5f33c9bdec176010

History

#1 Updated by Szilárd Páll over 4 years ago

  • Description updated (diff)

#2 Updated by Szilárd Páll over 4 years ago

  • Related to Bug #1838: Error building gromacs-5.1 with NVML support added

#3 Updated by Mark Abraham about 4 years ago

Is this resolved?

#4 Updated by Szilárd Páll about 4 years ago

No, it is not. The build system will still link against NVML if the dependencies are detected at any point. The user can't do much about it except reconfiguring and manually "hiding" some of the NVML components from CMake or by editing the cache manually.

#5 Updated by Mark Abraham about 4 years ago

  • Status changed from New to In Progress
  • Assignee set to Mark Abraham

#6 Updated by Gerrit Code Review Bot about 4 years ago

Gerrit received a related patchset '1' for Issue #1835.
Uploader: Mark Abraham ()
Change-Id: Ic1bf025fcd807eb701d0b52afe35b11b2d75f402
Gerrit URL: https://gerrit.gromacs.org/5549

#7 Updated by Mark Abraham about 4 years ago

  • Target version changed from 5.1.1 to 5.1.2

#8 Updated by Mark Abraham about 4 years ago

  • Status changed from In Progress to Fix uploaded

#9 Updated by Mark Abraham about 4 years ago

  • Status changed from Fix uploaded to Resolved

#10 Updated by Gerrit Code Review Bot about 4 years ago

Gerrit received a related patchset '1' for Issue #1835.
Uploader: Mark Abraham ()
Change-Id: I0fd640d4c431242e47e147bd5f33c9bdec176010
Gerrit URL: https://gerrit.gromacs.org/5582

#11 Updated by Mark Abraham about 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF