Project

General

Profile

Bug #1945

Lakcing checks in mdp option parsing

Added by Berk Hess over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
preprocessing (pdb2gmx,grompp)
Target version:
Affected version - extra info:
Affected version:
Difficulty:
uncategorized
Close

Description

An mdp option value in a multi-number field such as:
deform = (0.0 0.0 0.0 0.0 0.05 0.0)
silently is ignored by grompp (effect is then default settings).
There might be more checks missing.

Associated revisions

Revision da1b2cd4 (diff)
Added by Erik Lindahl over 3 years ago

Check number of items read in mdp statements

Added checks for the number of items read in all
sscanf() statements processing data from the mdp
file.

Fixes #1945.

Change-Id: Iecb5e3c7018570fb3a299624ac936c26d03294eb

History

#1 Updated by Gerrit Code Review Bot over 3 years ago

Gerrit received a related patchset '1' for Issue #1945.
Uploader: Erik Lindahl ()
Change-Id: Iecb5e3c7018570fb3a299624ac936c26d03294eb
Gerrit URL: https://gerrit.gromacs.org/5884

#2 Updated by Erik Lindahl over 3 years ago

  • Status changed from Accepted to Fix uploaded

Added checks for all sscanf() statements in readir.cpp.

#3 Updated by Erik Lindahl over 3 years ago

  • Target version set to 2016

#4 Updated by Erik Lindahl over 3 years ago

  • Status changed from Fix uploaded to Resolved

#5 Updated by Erik Lindahl over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF