Project

General

Profile

Bug #2000

cmake 3.5.1 + ninja not quite happy with dev-guide build system

Added by Mark Abraham over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
build system
Target version:
Affected version - extra info:
Affected version:
Difficulty:
uncategorized
Close

Description

With cmake 3.5.1 and master branch I see

CMake Warning (dev):
  Policy CMP0058 is not set: Ninja requires custom command byproducts to be
  explicit.  Run "cmake --help-policy CMP0058" for policy details.  Use the
  cmake_policy command to set the policy and suppress this warning.

  This project specifies custom command DEPENDS on files in the build tree
  that are not specified as the OUTPUT or BYPRODUCTS of any
  add_custom_command or add_custom_target:

   docs/sphinx-input/dev-manual/releng/index.rst

  For compatibility with versions of CMake that did not have the BYPRODUCTS
  option, CMake is generating phony rules for such files to convince 'ninja'
  to build.

  Project authors should add the missing BYPRODUCTS or OUTPUT options to the
  custom commands that produce these files.
This warning is for project developers.  Use -Wno-dev to suppress it.

which seems to be because in the absence of the releng repo(?) we generate a stub file at CMake time. Perhaps we can instead have a cmake target copy the stub from the source repo to the right place?

Associated revisions

Revision fef65292 (diff)
Added by Teemu Murtola over 4 years ago

Change handling for missing releng docs

Use a placeholder document from the source tree instead of generating it
on the fly in case RELENG_PATH is not set.

Also fix other warnings that got generated with RELENG_PATH not set.

Fixes #2000

Change-Id: I80b075a39eeff36e64b78cd58b09bc5bdde6ffad

History

#1 Updated by Teemu Murtola over 4 years ago

The CMake warning seems a bit overzealous, but shouldn't be too hard to fix.

#2 Updated by Teemu Murtola over 4 years ago

  • Category changed from documentation to build system
  • Status changed from New to Accepted
  • Assignee set to Teemu Murtola

#3 Updated by Gerrit Code Review Bot over 4 years ago

Gerrit received a related patchset '1' for Issue #2000.
Uploader: Teemu Murtola ()
Change-Id: I80b075a39eeff36e64b78cd58b09bc5bdde6ffad
Gerrit URL: https://gerrit.gromacs.org/6017

#4 Updated by Teemu Murtola over 4 years ago

  • Status changed from Accepted to Fix uploaded
  • Target version set to 2016

#5 Updated by Teemu Murtola over 4 years ago

  • Status changed from Fix uploaded to Resolved

#6 Updated by Erik Lindahl over 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF