Project

General

Profile

Bug #2105

multi-domain rerun broken

Added by Mark Abraham almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
mdrun
Target version:
Affected version - extra info:
all since 2016
Affected version:
Difficulty:
uncategorized
Close

Description

Some refactoring that converted !bNotLastFrame to bLastStep in 3da127 that was attempting to simplify do_md omitted to consider the logic in rerun_parallel_comm. This could lead to segfaults or infinite loops for reruns with more than one domain.

This case should have been covered by mdrun-test -nt 2 (or the newer mdrun-test -ntmpi 2 on master), which apparently has not been running in Jenkins for more than a year.


Related issues

Related to GROMACS - Task #1793: cleanup of integration loopNew
Related to GROMACS - Task #2134: assess whether Jenkins is testing multi-rank runs appropriatelyClosed

Associated revisions

Revision 2fc737df (diff)
Added by Mark Abraham almost 3 years ago

Fix multi-domain reruns

3da127 broke multi-domain rerun by failing to consider the
logic within rerun_parallel_comm.

Fixes #2105

Change-Id: I3b38a248a4fba5b3d46f0275add75948ef7a9c53

History

#1 Updated by Gerrit Code Review Bot almost 3 years ago

Gerrit received a related patchset '1' for Issue #2105.
Uploader: Mark Abraham ()
Change-Id: gromacs~release-2016~I3b38a248a4fba5b3d46f0275add75948ef7a9c53
Gerrit URL: https://gerrit.gromacs.org/6436

#2 Updated by Mark Abraham almost 3 years ago

  • Status changed from New to Resolved

#3 Updated by Mark Abraham almost 3 years ago

  • Related to Task #1793: cleanup of integration loop added

#5 Updated by Mark Abraham almost 3 years ago

  • Status changed from Resolved to Closed

#6 Updated by Mark Abraham over 2 years ago

  • Related to Task #2134: assess whether Jenkins is testing multi-rank runs appropriately added

Also available in: Atom PDF