Project

General

Profile

Bug #2324

mdrun signal description incorrect

Added by Berk Hess about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
documentation
Target version:
-
Affected version - extra info:
2016
Affected version:
Difficulty:
uncategorized
Close

Description

The mdrun help texts list different behavior for when receiving and TERM or an INT signal. But from the code and testing it seems the behavior is identical. So the help text should likely be updated.

Associated revisions

Revision 50d50553 (diff)
Added by Berk Hess about 2 years ago

Update mdrun signal help text

Updated mdrun help text on signal handling for old and recent changes
to the behavior.

Fixes #2324

Change-Id: I48dd30b7da3a1dc57331978c7d3b0e1509850187

History

#1 Updated by Gerrit Code Review Bot about 2 years ago

Gerrit received a related patchset '1' for Issue #2324.
Uploader: Berk Hess ()
Change-Id: gromacs~release-2018~I48dd30b7da3a1dc57331978c7d3b0e1509850187
Gerrit URL: https://gerrit.gromacs.org/7276

#2 Updated by Berk Hess about 2 years ago

  • Status changed from New to Fix uploaded

U uploaded a fix.
We might want to make no distinction between INT and TERM in the code, but I didn't want to do that in a release branch.

#3 Updated by Mark Abraham about 2 years ago

I'm all for simplicity - Ctrl-C is a hard exit ASAP, no checkpoint. We already have to support restarting in such scenarios from the old checkpoint, e.g. after power failure.

However, I think that the main use case for supporting the coordination leading to writing a checkpoint is to permit a job scheduler to send signals that lead to a graceful shutdown without wasting up to 15 minutes of parallel resources. That coincidentally means that Ctrl-C does things, but I think we shouldn't design the implementation around the use case on the terminal.

#4 Updated by Berk Hess about 2 years ago

  • Status changed from Fix uploaded to Resolved

OK. But then we need to change the behavior: INT should do the same thing as ABRT.

#6 Updated by Erik Lindahl almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF